Removes WmShelfAura and WmShelfMus

Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG=671246
TEST=none

Review-Url: https://codereview.chromium.org/2626483002
Cr-Commit-Position: refs/heads/master@{#442376}
Committed: https://chromium.googlesource.com/chromium/src/+/287fe73741d070d48c332cd95849bd73e2eb722e

[sky, 2017-01-09 18:59:45]

Description was changed from

==========
Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG=671246
TEST=none
==========

to

==========
Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG=671246
TEST=none
==========

[sky, 2017-01-09 18:59:45]

sky@chromium.org changed reviewers:
+ msw@chromium.org

[sky, 2017-01-09 18:59:50]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:00:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-01-09 19:13:56]

lgtm with an optional nit

https://codereview.chromium.org/2626483002/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2626483002/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.cc:359: // TODO(sky): this should be removed once
consolidate on Shell.
optional nit: grammar

[sky, 2017-01-09 19:16:35]

The CQ bit was checked by sky@chromium.org

[sky, 2017-01-09 19:16:36]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2626483002/#ps40001
(title: "grammar")

[commit-bot: I haz the power, 2017-01-09 19:16:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:43:30]

Failed to apply patch for ash/root_window_controller.cc:
While running git apply --index -p1;
  error: patch failed: ash/root_window_controller.cc:9
  error: ash/root_window_controller.cc: patch does not apply

Patch:       ash/root_window_controller.cc
Index: ash/root_window_controller.cc
diff --git a/ash/root_window_controller.cc b/ash/root_window_controller.cc
index
93a53208cdd9d29d1664559f6ed4332b685bf884..34cf0ee4534656370f0bcd73f41bba7c8b7d99bf
100644
--- a/ash/root_window_controller.cc
+++ b/ash/root_window_controller.cc
@@ -9,7 +9,6 @@
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_root_window_controller_aura.h"
-#include "ash/aura/wm_shelf_aura.h"
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/ash_constants.h"
 #include "ash/common/ash_switches.h"
@@ -19,6 +18,7 @@
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/shelf/shelf_layout_manager.h"
 #include "ash/common/shelf/shelf_widget.h"
+#include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/shell_delegate.h"
 #include "ash/common/system/status_area_layout_manager.h"
 #include "ash/common/system/status_area_widget.h"
@@ -293,10 +293,9 @@ void
RootWindowController::OnWallpaperAnimationFinished(views::Widget* widget) {
 void RootWindowController::CloseChildWindows() {
   // Remove observer as deactivating keyboard causes
   // docked_window_layout_manager() to fire notifications.
-  if (docked_window_layout_manager() &&
-      wm_shelf_aura_->shelf_layout_manager()) {
+  if (docked_window_layout_manager() && wm_shelf_->shelf_layout_manager()) {
     docked_window_layout_manager()->RemoveObserver(
-        wm_shelf_aura_->shelf_layout_manager());
+        wm_shelf_->shelf_layout_manager());
   }
 
   // Deactivate keyboard container before closing child windows and shutting
@@ -314,23 +313,23 @@ void RootWindowController::MoveWindowsTo(aura::Window*
dst) {
 }
 
 ShelfLayoutManager* RootWindowController::GetShelfLayoutManager() {
-  return wm_shelf_aura_->shelf_layout_manager();
+  return wm_shelf_->shelf_layout_manager();
 }
 
 StatusAreaWidget* RootWindowController::GetStatusAreaWidget() {
-  ShelfWidget* shelf_widget = wm_shelf_aura_->shelf_widget();
+  ShelfWidget* shelf_widget = wm_shelf_->shelf_widget();
   return shelf_widget ? shelf_widget->status_area_widget() : nullptr;
 }
 
 SystemTray* RootWindowController::GetSystemTray() {
   // We assume in throughout the code that this will not return NULL. If code
   // triggers this for valid reasons, it should test status_area_widget first.
-  CHECK(wm_shelf_aura_->shelf_widget()->status_area_widget());
-  return wm_shelf_aura_->shelf_widget()->status_area_widget()->system_tray();
+  CHECK(wm_shelf_->shelf_widget()->status_area_widget());
+  return wm_shelf_->shelf_widget()->status_area_widget()->system_tray();
 }
 
 void RootWindowController::UpdateShelfVisibility() {
-  wm_shelf_aura_->UpdateVisibilityState();
+  wm_shelf_->UpdateVisibilityState();
 }
 
 aura::Window* RootWindowController::GetWindowForFullscreenMode() {
@@ -345,7 +344,7 @@ void RootWindowController::ActivateKeyboard(
     return;
   }
   DCHECK(keyboard_controller);
-  keyboard_controller->AddObserver(wm_shelf_aura_->shelf_layout_manager());
+  keyboard_controller->AddObserver(wm_shelf_->shelf_layout_manager());
   keyboard_controller->AddObserver(panel_layout_manager());
   keyboard_controller->AddObserver(docked_window_layout_manager());
   keyboard_controller->AddObserver(workspace_controller()->layout_manager());
@@ -375,7 +374,7 @@ void RootWindowController::DeactivateKeyboard(
     // Virtual keyboard may be deactivated while still showing, notify all
     // observers that keyboard bounds changed to 0 before remove them.
     keyboard_controller->NotifyKeyboardBoundsChanging(gfx::Rect());
-   
keyboard_controller->RemoveObserver(wm_shelf_aura_->shelf_layout_manager());
+    keyboard_controller->RemoveObserver(wm_shelf_->shelf_layout_manager());
     keyboard_controller->RemoveObserver(panel_layout_manager());
     keyboard_controller->RemoveObserver(docked_window_layout_manager());
     keyboard_controller->RemoveObserver(
@@ -405,7 +404,7 @@ void RootWindowController::SetTouchAccessibilityAnchorPoint(
 
 RootWindowController::RootWindowController(AshWindowTreeHost* ash_host)
     : ash_host_(ash_host),
-      wm_shelf_aura_(new WmShelfAura),
+      wm_shelf_(base::MakeUnique<WmShelf>()),
       touch_hud_debug_(NULL),
       touch_hud_projection_(NULL) {
   aura::Window* root_window = GetRootWindow();
@@ -466,7 +465,7 @@ void RootWindowController::Init(RootWindowType
root_window_type) {
 
 void RootWindowController::InitLayoutManagers() {
   // Create the shelf and status area widgets.
-  DCHECK(!wm_shelf_aura_->shelf_widget());
+  DCHECK(!wm_shelf_->shelf_widget());
   aura::Window* shelf_container = GetContainer(kShellWindowId_ShelfContainer);
   aura::Window* status_container =
GetContainer(kShellWindowId_StatusContainer);
   WmWindow* wm_shelf_container = WmWindowAura::Get(shelf_container);
@@ -477,9 +476,9 @@ void RootWindowController::InitLayoutManagers() {
   // Make it easier to resize windows that partially overlap the shelf. Must
   // occur after the ShelfLayoutManager is constructed by ShelfWidget.
   shelf_container->SetEventTargeter(base::MakeUnique<ShelfWindowTargeter>(
-      wm_shelf_container, wm_shelf_aura_.get()));
+      wm_shelf_container, wm_shelf_.get()));
   status_container->SetEventTargeter(base::MakeUnique<ShelfWindowTargeter>(
-      wm_status_container, wm_shelf_aura_.get()));
+      wm_status_container, wm_shelf_.get()));
 
   panel_container_handler_ = base::MakeUnique<PanelWindowEventHandler>();
   GetContainer(kShellWindowId_PanelContainer)
@@ -557,7 +556,7 @@ PanelLayoutManager*
RootWindowController::panel_layout_manager() {
 }
 
 void RootWindowController::OnLoginStateChanged(LoginStatus status) {
-  wm_shelf_aura_->UpdateVisibilityState();
+  wm_shelf_->UpdateVisibilityState();
 }
 
 void RootWindowController::OnTouchHudProjectionToggled(bool enabled) {

[sky, 2017-01-09 21:01:14]

The CQ bit was checked by sky@chromium.org

[sky, 2017-01-09 21:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2626483002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-01-09 21:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 22:29:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483995674107740,
"parent_rev": "59bdd9ec771b134936b325af8b80b0ee5d8b8231", "commit_rev":
"287fe73741d070d48c332cd95849bd73e2eb722e"}

[commit-bot: I haz the power, 2017-01-09 22:29:50]

Description was changed from

==========
Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG=671246
TEST=none
==========

to

==========
Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG=671246
TEST=none

Review-Url: https://codereview.chromium.org/2626483002
Cr-Commit-Position: refs/heads/master@{#442376}
Committed:
https://chromium.googlesource.com/chromium/src/+/287fe73741d070d48c332cd95849...
==========

[commit-bot: I haz the power, 2017-01-09 22:29:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/287fe73741d070d48c332cd95849...