Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2626423003: Use DOMWindowClient for objects owned by LocalDOMWindow (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use DOMWindowClient for objects owned by LocalDOMWindow These objects should be a per-DOMWindow thing instead of a per-ExecutionContext thing. They should DOMWindowClient instead of ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2626423003 Cr-Commit-Position: refs/heads/master@{#443511} Committed: https://chromium.googlesource.com/chromium/src/+/d5231cdb20da617c9625996b6e552c0f498d1889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/core/frame/BarProp.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/BarProp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-13 05:33:11 UTC) #3
dcheng
LGTM
3 years, 11 months ago (2017-01-13 05:41:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626423003/1
3 years, 11 months ago (2017-01-13 06:00:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 06:52:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5231cdb20da617c9625996b6e55...

Powered by Google App Engine
This is Rietveld 408576698