Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 2626413003: Replace deprecated call to GetMetadata in Physical Web WebUI (Closed)

Created:
3 years, 11 months ago by mattreynolds
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated call to GetMetadata in Physical Web WebUI Use GetMetadataList instead of GetMetadata, which is now deprecated. Some unused WebUI string constants are also removed. BUG=667722 Review-Url: https://codereview.chromium.org/2626413003 Cr-Commit-Position: refs/heads/master@{#444464} Committed: https://chromium.googlesource.com/chromium/src/+/39fc60a2e04e46bac87333ee599a4c003c3955ef

Patch Set 1 #

Patch Set 2 : remove unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M components/physical_web/webui/physical_web_base_message_handler.cc View 2 chunks +20 lines, -8 lines 0 comments Download
M components/physical_web/webui/physical_web_ui_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/physical_web/webui/physical_web_ui_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/physical_web/webui/resources/physical_web.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mattreynolds
Hi Olivier, PTAL I'm moving our C++ clients from using the (now deprecated) base::ListValue interface ...
3 years, 11 months ago (2017-01-17 22:05:49 UTC) #3
Olivier
lgtm
3 years, 11 months ago (2017-01-18 08:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626413003/20001
3 years, 11 months ago (2017-01-18 19:13:37 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:34:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39fc60a2e04e46bac87333ee599a...

Powered by Google App Engine
This is Rietveld 408576698