Move Frame pointer to be held by DOMWindow base class.

Move Frame reference to be held by DOMWindow base class.

BUG=none

Review-Url: https://codereview.chromium.org/2626403002
Cr-Commit-Position: refs/heads/master@{#443501}
Committed: https://chromium.googlesource.com/chromium/src/+/9a7ed6355fcce1ca56ce57155639571880333052

[dcheng, 2017-01-12 23:35:39]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:36:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:07:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 02:07:06]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-13 03:25:19]

Description was changed from

==========
Move Frame pointer to be held by DOMWindow base class.

BUG=none
==========

to

==========
Move Frame reference to be held by DOMWindow base class.

BUG=none
==========

[dcheng, 2017-01-13 03:25:19]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2017-01-13 03:34:23]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 03:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-01-13 03:38:22]

By itself, this CL is just some small cleanup/refactoring. However, in a
followup, I'm planning on having DOMWindow also hold a reference to the
WindowProxyManager: this will allow the bindings to always convert a DOMWindow*
to a WindowProxy object. Having the frame available in the base class makes it
easy to get to the WindowProxyManager, rather than plumbing it as a separate
parameter.

Note that an alternate way to solve the detached DOMWindow bindings issue is to
not clear Frame: however, this is dangerous if code associated with a DOMWindow
isn't careful to check that frame->domWindow() == this. This has led to security
bugs in the past. WindowProxyManager currently also exposes frame() as a public
accessor, but this will be restricted in a followup patch as well =)

https://codereview.chromium.org/2626403002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/RemoteFrame.cpp (right):

https://codereview.chromium.org/2626403002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/RemoteFrame.cpp:111:
toRemoteDOMWindow(m_domWindow)->frameDetached();
I moved this out of setView() because it seems a little unrelated to have it
hooked in there.

[Yuki, 2017-01-13 03:52:56]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2017-01-13 03:52:56]

LGTM on my side.

[Yuki, 2017-01-13 03:55:02]

By the way, I'm trying to make a DOMWindow have an internal field which points
to the WindowProxy at:
https://codereview.chromium.org/2617733004/
(though it's not going well yet.)

[haraken, 2017-01-13 03:57:59]

LGTM

[dcheng, 2017-01-13 04:14:41]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-01-13 04:14:42]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:14:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 05:50:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484280882627610,
"parent_rev": "b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3", "commit_rev":
"9a7ed6355fcce1ca56ce57155639571880333052"}

[commit-bot: I haz the power, 2017-01-13 05:50:48]

Description was changed from

==========
Move Frame reference to be held by DOMWindow base class.

BUG=none
==========

to

==========
Move Frame reference to be held by DOMWindow base class.

BUG=none

Review-Url: https://codereview.chromium.org/2626403002
Cr-Commit-Position: refs/heads/master@{#443501}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a7ed6355fcce1ca56ce57155639...
==========

[commit-bot: I haz the power, 2017-01-13 05:50:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9a7ed6355fcce1ca56ce57155639...