Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2626383002: IME for Mus: EnumTraits for TextInputMode and TextInputType. (Closed)

Created:
3 years, 11 months ago by Hadi
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IME for Mus: EnumTraits for TextInputMode and TextInputType. * Adds EnumTraits for TextInputMode and TextInputType. * Adds corresponding unittests. * Adds missing enum entries in ime.mojom. BUG=631527 Review-Url: https://codereview.chromium.org/2626383002 Cr-Commit-Position: refs/heads/master@{#443463} Committed: https://chromium.googlesource.com/chromium/src/+/744bfc85a783e50ac5ae830fcdd5a9204df60d66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -16 lines) Patch
M chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/simple_input_method.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/simple_input_method.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/ime/ime.mojom View 2 chunks +7 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/ime/ime.typemap View 2 chunks +4 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits.h View 2 chunks +14 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits.cc View 1 chunk +188 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits_test.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits_unittest.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M ui/aura/mus/input_method_mus.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Hadi
sky@ PTAL. tsepez@ please review *.mojom and *_struct_traits_*. Thanks.
3 years, 11 months ago (2017-01-12 22:41:47 UTC) #4
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-12 23:32:56 UTC) #5
sky
LGTM
3 years, 11 months ago (2017-01-13 00:10:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626383002/1
3 years, 11 months ago (2017-01-13 01:17:43 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:13:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/744bfc85a783e50ac5ae830fcdd5...

Powered by Google App Engine
This is Rietveld 408576698