Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2626373003: Gtk3: Fix link color in 3.12 and later (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix link color in 3.12 and later Gtk changed the way links are colored in 3.12. This CL fixes a TODO that existed because we were only handling the <Gtk3.12 case. In addition, this CL also fixes compiling with use_gtk3=true when using the jessie sysroot by removing a deprecation warning. BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2626373003 Cr-Commit-Position: refs/heads/master@{#443673} Committed: https://chromium.googlesource.com/chromium/src/+/0a2e2fe2fcbf723c89d7fce95e980c062231b316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom (Use chromium acct)
3 years, 11 months ago (2017-01-13 02:28:24 UTC) #1
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-13 19:14:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626373003/40001
3 years, 11 months ago (2017-01-13 19:17:37 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:21:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0a2e2fe2fcbf723c89d7fce95e98...

Powered by Google App Engine
This is Rietveld 408576698