Rename a few compositor property tree methods for clarity.

Rename a few compositor property tree methods for clarity.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2626353002
Cr-Commit-Position: refs/heads/master@{#443681}
Committed: https://chromium.googlesource.com/chromium/src/+/c51a822ea88495a1a4de015933f940b8618db0dd

[wkorman, 2017-01-12 22:15:44]

Description was changed from

==========
Rename a few compositor property tree methods for clarity.

BUG=674258
==========

to

==========
Rename a few compositor property tree methods for clarity.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-01-12 22:20:58]

wkorman@chromium.org changed reviewers:
+ ajuma@chromium.org, pdr@chromium.org

[wkorman, 2017-01-12 22:20:59]

Notes:

- compositorIdForXxx() methods actually create compositor property tree nodes,
whereas the name implies they are more pure accessors. ensureXxx() seems a
better fit but open to thoughts.

- a case could be made for moving PropertyTreeManager to its own file, thoughts?
Pros:
  + would allow writing more focused unit tests around its logic which is quite
complex
  + would move ~550 lines of code out of PaintArtifactCompositor
  + (personal opinion) would make it easier to maintain

  I get that it's an internal implementation detail of how PAC does its work,
  but we could enforce that if we cared to do so by making it private and having
  PAC be the only friend. I'm not sure what common pattern is used for similar
  elsewhere in Blink, but I have to imagine we like to avoid having 5K+ LOC in a
  single file and so this must have been surmounted previously in some manner.

[wkorman, 2017-01-12 22:25:15]

On 2017/01/12 at 22:20:59, wkorman wrote:
> ...but I have to imagine we like to avoid having 5K+ LOC in a
>   single file and so this must have been surmounted previously in some manner.

This was a bit of hand-waving melodrama, the file is currently 1242 lines, but
5K+ could well await us in the future if we don't take steps now!

I'm not saying it could turn into 8K or even 20K, I'm just saying it could
keep growing.

http://changingminds.org/techniques/general/sequential/top_line.htm

[ajuma, 2017-01-13 00:52:36]

lgtm, I've been confused by these names before when reading this code

[pdr., 2017-01-13 05:03:04]

On 2017/01/13 at 00:52:36, ajuma wrote:
> lgtm, I've been confused by these names before when reading this code

LGTM!

[wkorman, 2017-01-13 17:40:32]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-01-13 17:40:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2626353002/#ps20001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-01-13 17:40:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:41:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484329232638130,
"parent_rev": "a4da1090fe1db585d1c86a7a35e80d0859d403b0", "commit_rev":
"c51a822ea88495a1a4de015933f940b8618db0dd"}

[commit-bot: I haz the power, 2017-01-13 21:42:45]

Description was changed from

==========
Rename a few compositor property tree methods for clarity.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename a few compositor property tree methods for clarity.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2626353002
Cr-Commit-Position: refs/heads/master@{#443681}
Committed:
https://chromium.googlesource.com/chromium/src/+/c51a822ea88495a1a4de015933f9...
==========

[commit-bot: I haz the power, 2017-01-13 21:42:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c51a822ea88495a1a4de015933f9...