Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 2626323002: Android: Write all proguard flags to out.jar.flags file (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Write all proguard flags to out.jar.flags file This is to help with debugging / auditing of proguard flags. BUG=none Review-Url: https://codereview.chromium.org/2626323002 Cr-Commit-Position: refs/heads/master@{#443765} Committed: https://chromium.googlesource.com/chromium/src/+/848c2e8399cd8aca05c31f555d29ba6b9a68d3ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M build/android/gyp/util/proguard_util.py View 2 chunks +17 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/01/12 20:54:32, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:ianwen@chromium.org 📉
3 years, 11 months ago (2017-01-12 20:54:44 UTC) #3
Ian Wen
lgtm
3 years, 11 months ago (2017-01-14 00:25:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626323002/1
3 years, 11 months ago (2017-01-14 00:25:48 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:45:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/848c2e8399cd8aca05c31f555d29...

Powered by Google App Engine
This is Rietveld 408576698