DevTools: split ProfilesPanel into multiple files.

DevTools: split ProfilesPanel into multiple files.

Review-Url: https://codereview.chromium.org/2626313002
Cr-Commit-Position: refs/heads/master@{#443502}
Committed: https://chromium.googlesource.com/chromium/src/+/5739add10c75198926cea1a66772ab04df47ad51

[pfeldman, 2017-01-12 20:11:19]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[pfeldman, 2017-01-12 20:11:25]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-12 20:11:28]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-12 20:11:37]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-12 20:20:11]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org

[pfeldman, 2017-01-12 20:21:42]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-12 20:23:30]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-01-12 20:48:30]

Please adjust --similarity so the code you've moved wouldn't look like new.

https://codereview.chromium.org/2626313002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/MemoryProfilerPanel.js
(right):

https://codereview.chromium.org/2626313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/MemoryProfilerPanel.js:10:
constructor() {
redundant

[alph, 2017-01-12 21:23:19]

lgtm

[pfeldman, 2017-01-12 21:28:34]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:29:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-12 21:49:59]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-01-12 21:50:21]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:55:11]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/profiler/module.json:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/profiler/module.json:77
  error: third_party/WebKit/Source/devtools/front_end/profiler/module.json:
patch does not apply

Patch:       third_party/WebKit/Source/devtools/front_end/profiler/module.json
Index: third_party/WebKit/Source/devtools/front_end/profiler/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/module.json
b/third_party/WebKit/Source/devtools/front_end/profiler/module.json
index
f3122232a11234bb53d660eb21ab6efe6d9681c5..76a1f0a936e20d7d170ab23611b60f9306d0fd07
100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/module.json
@@ -15,7 +15,7 @@
             "id": "profiles",
             "title": "Memory",
             "order": 60,
-            "className": "Profiler.ProfilesPanel",
+            "className": "Profiler.MemoryProfilerPanel",
             "condition": "!v8only"
         },
         {
@@ -23,7 +23,7 @@
             "contextTypes": [
                 "SDK.RemoteObject"
             ],
-            "className": "Profiler.ProfilesPanel.ContextMenuProvider"
+            "className": "Profiler.MemoryProfilerPanel"
         },
         {
             "type": "setting",
@@ -56,9 +56,9 @@
             "toggledIconClass": "largeicon-stop-recording",
             "toggleWithRedColor": true,
             "contextTypes": [
-                "Profiler.ProfilesPanel"
+                "Profiler.MemoryProfilerPanel"
             ],
-            "className": "Profiler.ProfilesPanel.RecordActionDelegate",
+            "className": "Profiler.MemoryProfilerPanel",
             "bindings": [
                 {
                     "platform": "windows,linux",
@@ -77,6 +77,8 @@
         "data_grid"
     ],
     "scripts": [
+        "ProfileType.js",
+        "ProfileHeader.js",
         "ProfilesPanel.js",
         "ProfileView.js",
         "ProfileDataGrid.js",
@@ -90,6 +92,7 @@
         "HeapSnapshotDataGrids.js",
         "HeapSnapshotGridNodes.js",
         "HeapSnapshotView.js",
+        "MemoryProfilerPanel.js",
         "ProfileLauncherView.js",
         "ProfileTypeRegistry.js",
         "TargetsComboBoxController.js"

[pfeldman, 2017-01-13 02:08:16]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-01-13 02:09:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 02:17:42]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/profiler/module.json:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/profiler/module.json:77
  error: third_party/WebKit/Source/devtools/front_end/profiler/module.json:
patch does not apply

Patch:       third_party/WebKit/Source/devtools/front_end/profiler/module.json
Index: third_party/WebKit/Source/devtools/front_end/profiler/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/module.json
b/third_party/WebKit/Source/devtools/front_end/profiler/module.json
index
f3122232a11234bb53d660eb21ab6efe6d9681c5..76a1f0a936e20d7d170ab23611b60f9306d0fd07
100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/module.json
@@ -15,7 +15,7 @@
             "id": "profiles",
             "title": "Memory",
             "order": 60,
-            "className": "Profiler.ProfilesPanel",
+            "className": "Profiler.MemoryProfilerPanel",
             "condition": "!v8only"
         },
         {
@@ -23,7 +23,7 @@
             "contextTypes": [
                 "SDK.RemoteObject"
             ],
-            "className": "Profiler.ProfilesPanel.ContextMenuProvider"
+            "className": "Profiler.MemoryProfilerPanel"
         },
         {
             "type": "setting",
@@ -56,9 +56,9 @@
             "toggledIconClass": "largeicon-stop-recording",
             "toggleWithRedColor": true,
             "contextTypes": [
-                "Profiler.ProfilesPanel"
+                "Profiler.MemoryProfilerPanel"
             ],
-            "className": "Profiler.ProfilesPanel.RecordActionDelegate",
+            "className": "Profiler.MemoryProfilerPanel",
             "bindings": [
                 {
                     "platform": "windows,linux",
@@ -77,6 +77,8 @@
         "data_grid"
     ],
     "scripts": [
+        "ProfileType.js",
+        "ProfileHeader.js",
         "ProfilesPanel.js",
         "ProfileView.js",
         "ProfileDataGrid.js",
@@ -90,6 +92,7 @@
         "HeapSnapshotDataGrids.js",
         "HeapSnapshotGridNodes.js",
         "HeapSnapshotView.js",
+        "MemoryProfilerPanel.js",
         "ProfileLauncherView.js",
         "ProfileTypeRegistry.js",
         "TargetsComboBoxController.js"

[pfeldman, 2017-01-13 02:21:31]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-13 02:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2626313002/#ps100001
(title: "rebaselined")

[commit-bot: I haz the power, 2017-01-13 02:22:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 05:57:33]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484274091180270,
"parent_rev": "9a7ed6355fcce1ca56ce57155639571880333052", "commit_rev":
"5739add10c75198926cea1a66772ab04df47ad51"}

[commit-bot: I haz the power, 2017-01-13 05:58:53]

Description was changed from

==========
DevTools: split ProfilesPanel into multiple files.
==========

to

==========
DevTools: split ProfilesPanel into multiple files.

Review-Url: https://codereview.chromium.org/2626313002
Cr-Commit-Position: refs/heads/master@{#443502}
Committed:
https://chromium.googlesource.com/chromium/src/+/5739add10c75198926cea1a66772...
==========

[commit-bot: I haz the power, 2017-01-13 05:58:54]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5739add10c75198926cea1a66772...