[InfoBar] Always close native infobars from C++. Part II

Split the dismiss call for C++ and java
BUG=283720
Test=Run InfoBarTest and TranslateInfoBarTest which already contain tests for these cases
Tried manually all cases as well.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229095

[Miguel Garcia, 2013-10-07 15:15:37]

On 2013/10/07 15:14:30, Miguel Garcia wrote:

Depends on part I https://codereview.chromium.org/26176007/

[gone, 2013-10-07 17:10:03]

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
(right):

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:389:
infoBar.dismissJavaOnlyInfoBar();
Does the native side code properly dismiss native infobars in this case?

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
(right):

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java:52:
private final int mNativeInfoBarPtr;
I don't think it makes sense for the subclass to have another mNativeInfoBarPtr
when the super class already has a member variable called that.  Do you use this
one, or can you use the super class'?

[Miguel Garcia, 2013-10-10 14:49:48]

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
(right):

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:389:
infoBar.dismissJavaOnlyInfoBar();
On 2013/10/07 17:10:03, dfalcantara wrote:
> Does the native side code properly dismiss native infobars in this case?

Yes, that was handled in part I already.

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
(right):

https://codereview.chromium.org/26263002/diff/3001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java:52:
private final int mNativeInfoBarPtr;
On 2013/10/07 17:10:03, dfalcantara wrote:
> I don't think it makes sense for the subclass to have another
mNativeInfoBarPtr
> when the super class already has a member variable called that.  Do you use
this
> one, or can you use the super class'?

I can use the one in the parent class but I thought it'd be a good idea to works
towards making the parent one private an have those child infobars that also
need it keep their own reference. Happy to change it back if you feel strongly
about it.

[gone, 2013-10-15 00:24:26]

lgtm

Sorry, this one fell off my radar.

[commit-bot: I haz the power, 2013-10-16 10:30:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/26263002/14001

[commit-bot: I haz the power, 2013-10-16 15:27:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/26263002/14001

[commit-bot: I haz the power, 2013-10-17 09:02:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/26263002/14001

[commit-bot: I haz the power, 2013-10-17 10:54:30]

Change committed as 229095