chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java - Issue 26263002: [InfoBar] Always close native infobars from C++. Part II

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

Issue 26263002: [InfoBar] Always close native infobars from C++. Part II (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/MessageInfoBar.java ('k') | chrome/browser/ui/android/infobars/infobar_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

index 3d3b1899600687704e1e7c8b8e9b23b991b02caf..dfb1d13892d318651117e909d94705f452ce81ea 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

@@ -49,6 +49,7 @@ public class TranslateInfoBar extends TwoButtonInfoBar implements SubPanelListen

private TranslateSubPanel mSubPanel;

private final boolean mShouldShowNeverBar;

private final TranslateInfoBarDelegate mTranslateDelegate;

+ private final int mNativeInfoBarPtr;

public TranslateInfoBar(int nativeInfoBarPtr, TranslateInfoBarDelegate delegate,

int infoBarType, int sourceLanguageIndex, int targetLanguageIndex,

@@ -61,6 +62,7 @@ public class TranslateInfoBar extends TwoButtonInfoBar implements SubPanelListen

mInfoBarType = infoBarType;

mShouldShowNeverBar = shouldShowNeverBar;

mOptionsPanelViewType = NO_PANEL;

+ mNativeInfoBarPtr = nativeInfoBarPtr;

setNativeInfoBar(nativeInfoBarPtr);

}

@@ -70,8 +72,7 @@ public class TranslateInfoBar extends TwoButtonInfoBar implements SubPanelListen

// Make it behave exactly as the Nope Button.

onButtonClicked(false);

} else {

- // Just close the infobar

- super.onCloseButtonClicked();

+ nativeOnCloseButtonClicked(mNativeInfoBarPtr);

}