exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo interface pointer

exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo interface pointer

This fixes the performance regression on arm devices.

BUG=680066
Review-Url: https://codereview.chromium.org/2626293005
Cr-Commit-Position: refs/heads/master@{#443712}
Committed: https://chromium.googlesource.com/chromium/src/+/c43626b432c288cc3b08e46b3a7f813e95d6d773

[Alex Z., 2017-01-13 17:54:18]

staraz@chromium.org changed reviewers:
+ fsamuel@chromium.org, reveman@chromium.org

[Alex Z., 2017-01-13 17:54:19]

Please review my changes.

[Alex Z., 2017-01-13 17:54:38]

Description was changed from

==========
exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo
interface pointer

BUG=680066
==========

to

==========
exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo
interface pointer

This fixes the performance regression on arm devices.

BUG=680066
==========

[Fady Samuel, 2017-01-13 19:14:28]

https://codereview.chromium.org/2626293005/diff/1/components/exo/compositor_f...
File components/exo/compositor_frame_sink.h (right):

https://codereview.chromium.org/2626293005/diff/1/components/exo/compositor_f...
components/exo/compositor_frame_sink.h:51:
mojo::StrongBindingPtr<cc::mojom::MojoCompositorFrameSink> binding_;
Try restoring the existing code and making this binding_ the first member
variable. Make CompositorFrameSinkSupport the last member variable.

This would cause CompositorFrameSinkSupport to be destroyed first, and
mojo::StrongBindingPtr<cc::mojom::MojoCompositorFrameSink> to be destroyed last.
I'm curious what would happen.

[Fady Samuel, 2017-01-13 22:09:13]

lgtm

[reveman, 2017-01-13 22:15:13]

lgtm % nit

https://codereview.chromium.org/2626293005/diff/20001/components/exo/composit...
File components/exo/compositor_frame_sink.h (right):

https://codereview.chromium.org/2626293005/diff/20001/components/exo/composit...
components/exo/compositor_frame_sink.h:49: CompositorFrameSinkHolder* client_;
nit: CompositorFrameSinkHolder* const client_

[Alex Z., 2017-01-13 22:16:56]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-01-13 22:16:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2626293005/#ps40001
(title: "Addressed nit")

[commit-bot: I haz the power, 2017-01-13 22:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:05:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484345816960990,
"parent_rev": "d8028087727891a6575e8209daecf58035a95723", "commit_rev":
"c43626b432c288cc3b08e46b3a7f813e95d6d773"}

[commit-bot: I haz the power, 2017-01-13 23:05:40]

Description was changed from

==========
exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo
interface pointer

This fixes the performance regression on arm devices.

BUG=680066
==========

to

==========
exo::CompositorFrameSink uses CompositorFrameSinkHolder* instead of mojo
interface pointer

This fixes the performance regression on arm devices.

BUG=680066

Review-Url: https://codereview.chromium.org/2626293005
Cr-Commit-Position: refs/heads/master@{#443712}
Committed:
https://chromium.googlesource.com/chromium/src/+/c43626b432c288cc3b08e46b3a7f...
==========

[commit-bot: I haz the power, 2017-01-13 23:05:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c43626b432c288cc3b08e46b3a7f...