Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2626283005: Fix polymer import issue in options after changes in lock_screen.html (Closed)

Created:
3 years, 11 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 11 months ago
Reviewers:
jdufault, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix polymer import issue in options after changes in lock_screen.html BUG=681169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2626283005 Cr-Commit-Position: refs/heads/master@{#444112} Committed: https://chromium.googlesource.com/chromium/src/+/bb33e323f188305ac1583c6394e0b5dc1b32f356

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options_resources.grd View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
xiaoyinh(OOO Sep 11-29)
dbeam@, jdufault@, please take a look. Thanks!
3 years, 11 months ago (2017-01-13 21:50:03 UTC) #6
jdufault
lgtm
3 years, 11 months ago (2017-01-13 21:53:43 UTC) #7
Dan Beam
lgtm i still think using /settings/ in /options/ is nuts, though
3 years, 11 months ago (2017-01-14 01:21:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626283005/20001
3 years, 11 months ago (2017-01-17 19:28:25 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:42:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb33e323f188305ac1583c6394e0...

Powered by Google App Engine
This is Rietveld 408576698