Add browser test for getusermedia and unavailable audio device.

Add browser test for getusermedia and unavailable audio device.
This test checks if we report an error when we fail to open an
audio stream at the AudioManager level.

BUG=679210
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626263006
Cr-Commit-Position: refs/heads/master@{#443887}
Committed: https://chromium.googlesource.com/chromium/src/+/2d756ffa10cb0081b976d259d76aabf05018066b

[tommi (sloooow) - chröme, 2017-01-14 14:08:35]

Description was changed from

==========
Add browser test for getusermedia and unavailable audio device.
This test checks if we report an error when we fail to open an
audio stream at the AudioManager level.

BUG=679210
==========

to

==========
Add browser test for getusermedia and unavailable audio device.
This test checks if we report an error when we fail to open an
audio stream at the AudioManager level.

BUG=679210
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tommi (sloooow) - chröme, 2017-01-14 14:08:47]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 14:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 14:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 14:18:15]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[tommi (sloooow) - chröme, 2017-01-15 16:23:36]

Move impl to cc

[tommi (sloooow) - chröme, 2017-01-15 16:24:02]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 16:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 16:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 16:51:09]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tommi (sloooow) - chröme, 2017-01-15 17:16:32]

Fix expectation

[tommi (sloooow) - chröme, 2017-01-15 17:18:03]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 17:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommi (sloooow) - chröme, 2017-01-15 17:18:14]

tommi@chromium.org changed reviewers:
+ henrika@chromium.org

[tommi (sloooow) - chröme, 2017-01-15 17:29:15]

Hmm, sorry the regular review request email wasn't sent out.  Can you
please take a look?

On Sun, Jan 15, 2017 at 6:18 PM <tommi@chromium.org> wrote:

> https://codereview.chromium.org/2626263006/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-01-15 18:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 18:30:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tommi (sloooow) - chröme, 2017-01-15 22:05:44]

Disable on android

[tommi (sloooow) - chröme, 2017-01-15 22:05:50]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 22:06:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 23:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 23:32:45]

Dry run: This issue passed the CQ dry run.

[henrika (OOO until Aug 14), 2017-01-16 09:13:20]

Nice. 

LGTM

[henrika (OOO until Aug 14), 2017-01-16 09:13:28]

https://codereview.chromium.org/2626263006/diff/60001/content/browser/webrtc/...
File content/browser/webrtc/webrtc_getusermedia_browsertest.cc (right):

https://codereview.chromium.org/2626263006/diff/60001/content/browser/webrtc/...
content/browser/webrtc/webrtc_getusermedia_browsertest.cc:598:
media::AudioManager::Get()->SetMaxStreamCountForTesting(0, 0);
Perhaps a comment explaining why we know the test should fail after calling this
method. Just an idea.

[tommi (sloooow) - chröme, 2017-01-16 12:37:01]

https://codereview.chromium.org/2626263006/diff/60001/content/browser/webrtc/...
File content/browser/webrtc/webrtc_getusermedia_browsertest.cc (right):

https://codereview.chromium.org/2626263006/diff/60001/content/browser/webrtc/...
content/browser/webrtc/webrtc_getusermedia_browsertest.cc:598:
media::AudioManager::Get()->SetMaxStreamCountForTesting(0, 0);
On 2017/01/16 09:13:27, henrika wrote:
> Perhaps a comment explaining why we know the test should fail after calling
this
> method. Just an idea.

Done.

[tommi (sloooow) - chröme, 2017-01-16 12:37:17]

Add comment

[tommi (sloooow) - chröme, 2017-01-16 12:37:26]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2017-01-16 12:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@chromium.org
Link to the patchset: https://codereview.chromium.org/2626263006/#ps80001
(title: "Add comment")

[commit-bot: I haz the power, 2017-01-16 12:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 14:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484570246330070,
"parent_rev": "1bb2f878c384dc07a0aca0476a3e0d51e879b2eb", "commit_rev":
"2d756ffa10cb0081b976d259d76aabf05018066b"}

[commit-bot: I haz the power, 2017-01-16 14:09:33]

Description was changed from

==========
Add browser test for getusermedia and unavailable audio device.
This test checks if we report an error when we fail to open an
audio stream at the AudioManager level.

BUG=679210
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add browser test for getusermedia and unavailable audio device.
This test checks if we report an error when we fail to open an
audio stream at the AudioManager level.

BUG=679210
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626263006
Cr-Commit-Position: refs/heads/master@{#443887}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d756ffa10cb0081b976d259d76a...
==========

[commit-bot: I haz the power, 2017-01-16 14:09:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2d756ffa10cb0081b976d259d76a...