Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2626263002: PPC/s390: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [TypeFeedbackVector] Root literal arrays in function literals slots Port b8294aaa978e972978b8d82cedf63befad5d7af1 Original Commit Message: Literal arrays and feedback vectors for a function can be garbage collected if we don't have a rooted closure for the function, which happens often. It's expensive to come back from this (recreating boilerplates and gathering feedback again), and the cost is disproportionate if the function was inlined into optimized code. To guard against losing these arrays when we need them, we'll now create literal arrays when creating the feedback vector for the outer closure, and root them strongly in that vector. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5456 LOG=N Review-Url: https://codereview.chromium.org/2626263002 Cr-Commit-Position: refs/heads/master@{#42280} Committed: https://chromium.googlesource.com/v8/v8/+/be781e51f577723881d29028815d70270c9dc658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +8 lines, -15 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-12 16:35:27 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-12 17:25:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626263002/1
3 years, 11 months ago (2017-01-12 17:33:25 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:57:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/be781e51f577723881d29028815d70270c9...

Powered by Google App Engine
This is Rietveld 408576698