Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2626243002: Add some <base> metrics to guide experimentation. (Closed)

Created:
3 years, 11 months ago by Mike West
Modified:
3 years, 11 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some <base> metrics to guide experimentation. <base> has cropped up in some recent attacks, and maybe it's possible to tweak things a little bit to make it play better with the platform at large. Let's find out, shall we? BUG=679318 Review-Url: https://codereview.chromium.org/2626243002 Cr-Commit-Position: refs/heads/master@{#443370} Committed: https://chromium.googlesource.com/chromium/src/+/80883f862b84159e61a786edc04f5159afcb1267

Patch Set 1 #

Patch Set 2 : One more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 3 chunks +21 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +14 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Mike West
jochen@: WDYT about adding some metrics?
3 years, 11 months ago (2017-01-12 13:00:47 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 13:07:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626243002/20001
3 years, 11 months ago (2017-01-12 21:28:04 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:38:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80883f862b84159e61a786edc04f...

Powered by Google App Engine
This is Rietveld 408576698