Show the exact cache size for time ranges if supported

Show the exact cache size for time ranges if supported. This will show the right cache size when a time range is selected on linux and android, where SimpleBackend is used for caching. Windows will still show the upper estimate because there is no efficient way to determine the cache size in the blockfile cache.

BUG=671196
BASE=2626173003

Review-Url: https://codereview.chromium.org/2626223002
Cr-Commit-Position: refs/heads/master@{#444335}
Committed: https://chromium.googlesource.com/chromium/src/+/de9e5f3b8c67ff572ca76b292b5a51bf474e8d4f

[dullweber, 2017-01-12 12:52:55]

Description was changed from

==========
implement exact cache counting if supported

BUG=671196
==========

to

==========
Use exact cache counting for time ranges if supported.

BUG=671196
==========

[dullweber, 2017-01-12 12:53:02]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 12:53:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-01-12 12:56:29]

Description was changed from

==========
Use exact cache counting for time ranges if supported.

BUG=671196
==========

to

==========
Use exact cache counting for time ranges if supported. This will show the right
cache size on linux and android, where SimpleBackend is used for caching and
show the upper estimate on Windows for the blockfile cache

BUG=671196
==========

[dullweber, 2017-01-12 12:56:29]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org

[commit-bot: I haz the power, 2017-01-12 13:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 13:07:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dullweber, 2017-01-12 14:26:21]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 14:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-01-12 14:44:07]

browsing_data/ LGTM

https://codereview.chromium.org/2626223002/diff/40001/chrome/browser/browsing...
File
chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc
(right):

https://codereview.chromium.org/2626223002/diff/40001/chrome/browser/browsing...
chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc:94:
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(kTimeoutMs));
nit: This Sleep() is here because of |t3|? Then please move |t3| right behind
this line so that it's obvious.

https://codereview.chromium.org/2626223002/diff/40001/components/browsing_dat...
File components/browsing_data/content/conditional_cache_counting_helper.cc
(right):

https://codereview.chromium.org/2626223002/diff/40001/components/browsing_dat...
components/browsing_data/content/conditional_cache_counting_helper.cc:145: rv =
cache_->CalculateSizeOfEntriesBetween(
This is based on top of 2626173003, right? Please mention it in the CL
description.

"BASE=2626173003"

[dullweber, 2017-01-12 15:02:48]

Description was changed from

==========
Use exact cache counting for time ranges if supported. This will show the right
cache size on linux and android, where SimpleBackend is used for caching and
show the upper estimate on Windows for the blockfile cache

BUG=671196
==========

to

==========
Use exact cache counting for time ranges if supported. This will show the right
cache size on linux and android, where SimpleBackend is used for caching and
show the upper estimate on Windows for the blockfile cache

BUG=671196
BASE=2626173003
==========

[dullweber, 2017-01-12 15:03:42]

https://codereview.chromium.org/2626223002/diff/40001/chrome/browser/browsing...
File
chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc
(right):

https://codereview.chromium.org/2626223002/diff/40001/chrome/browser/browsing...
chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc:94:
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(kTimeoutMs));
On 2017/01/12 14:44:07, msramek wrote:
> nit: This Sleep() is here because of |t3|? Then please move |t3| right behind
> this line so that it's obvious.

The issue is that DoomEntriesBetween on the SimpleBackend adds 1 second   before
and after the time interval. I copied this behavior for the counter to have it
consistent. So if I only want to get the entries between t1 and t2 I need 1
second after t2. When I only want to get entries between t2 and t3 I need 1
second before t2.

https://codereview.chromium.org/2626223002/diff/40001/components/browsing_dat...
File components/browsing_data/content/conditional_cache_counting_helper.cc
(right):

https://codereview.chromium.org/2626223002/diff/40001/components/browsing_dat...
components/browsing_data/content/conditional_cache_counting_helper.cc:145: rv =
cache_->CalculateSizeOfEntriesBetween(
On 2017/01/12 14:44:07, msramek wrote:
> This is based on top of 2626173003, right? Please mention it in the CL
> description.
> 
> "BASE=2626173003"

Done.

[commit-bot: I haz the power, 2017-01-12 15:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:20:39]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-01-16 10:25:46]

Description was changed from

==========
Use exact cache counting for time ranges if supported. This will show the right
cache size on linux and android, where SimpleBackend is used for caching and
show the upper estimate on Windows for the blockfile cache

BUG=671196
BASE=2626173003
==========

to

==========
Show the exact cache size for time ranges if supported. This will show the right
cache size when a time range is selected on linux and android, where
SimpleBackend is used for caching. Windows will still show the upper estimate
because there is no efficient way to determine the cache size in the blockfile
cache.

BUG=671196
BASE=2626173003
==========

[dullweber, 2017-01-16 10:31:49]

dullweber@chromium.org changed reviewers:
+ dbeam@chromium.org

[dullweber, 2017-01-16 10:31:49]

dbeam@chromium.org: Please review changes in 	 chrome/browser/ui/webui/options/
and .../settings/

[Dan Beam, 2017-01-18 02:21:56]

lgtm

[dullweber, 2017-01-18 09:15:14]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-01-18 09:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 09:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 09:17:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dullweber, 2017-01-18 10:58:46]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-01-18 10:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2626223002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-18 10:58:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 11:35:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484737126632480,
"parent_rev": "b06c17f5fe6d769739ca8b669690f305e0860c8e", "commit_rev":
"de9e5f3b8c67ff572ca76b292b5a51bf474e8d4f"}

[commit-bot: I haz the power, 2017-01-18 11:36:16]

Description was changed from

==========
Show the exact cache size for time ranges if supported. This will show the right
cache size when a time range is selected on linux and android, where
SimpleBackend is used for caching. Windows will still show the upper estimate
because there is no efficient way to determine the cache size in the blockfile
cache.

BUG=671196
BASE=2626173003
==========

to

==========
Show the exact cache size for time ranges if supported. This will show the right
cache size when a time range is selected on linux and android, where
SimpleBackend is used for caching. Windows will still show the upper estimate
because there is no efficient way to determine the cache size in the blockfile
cache.

BUG=671196
BASE=2626173003

Review-Url: https://codereview.chromium.org/2626223002
Cr-Commit-Position: refs/heads/master@{#444335}
Committed:
https://chromium.googlesource.com/chromium/src/+/de9e5f3b8c67ff572ca76b292b5a...
==========

[commit-bot: I haz the power, 2017-01-18 11:36:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/de9e5f3b8c67ff572ca76b292b5a...