Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2626183005: Gtk3: Remove box-shadow when rendering background colors (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Remove box-shadow when rendering background colors Some themes add internal box-shadows to widgets. In this case, GetBgColor() would return a darker color than it's supposed to. This CL overrides 'box-shadow' to 'none' to get an accurate color. Also, override 'outline' to 'none' too, just to be safe. BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2626183005 Cr-Commit-Position: refs/heads/master@{#443770} Committed: https://chromium.googlesource.com/chromium/src/+/c38f883945d7981f8c3fa0440579f5e56bb613ec

Patch Set 1 #

Patch Set 2 : Gtk3: Remove box-shadow when rendering background colors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom (Use chromium acct)
3 years, 11 months ago (2017-01-14 00:24:52 UTC) #1
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-14 01:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626183005/20001
3 years, 11 months ago (2017-01-14 01:18:54 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 02:16:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c38f883945d7981f8c3fa0440579...

Powered by Google App Engine
This is Rietveld 408576698