Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2626183004: W3C test importer: Fix path to manifest command. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C test importer: Fix path to manifest command. This is a follow-up fix to http://crrev.com/2630493002. In that CL, I changed the path to the manifest command but used the wrong path, resulting in the latest import failing: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7868 The manifest script is actually checked into: https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest BUG=678077 Review-Url: https://codereview.chromium.org/2626183004 Cr-Commit-Position: refs/heads/master@{#443480} Committed: https://chromium.googlesource.com/chromium/src/+/198405bd55b43aa21b7d76e4188fa44528c2bdc3

Patch Set 1 #

Patch Set 2 : Include gitignore module #

Patch Set 3 : Update unit test #

Messages

Total messages: 23 (15 generated)
qyearsley
3 years, 11 months ago (2017-01-13 00:44:29 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-13 00:45:04 UTC) #3
qyearsley
On 2017/01/13 at 00:45:04, jeffcarp wrote: > lgtm Thanks :-)
3 years, 11 months ago (2017-01-13 00:45:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626183004/1
3 years, 11 months ago (2017-01-13 00:46:48 UTC) #9
qyearsley
Actually, upon trying this, I see that it didn't quite work yet - in http://crrev.com/2630493002 ...
3 years, 11 months ago (2017-01-13 00:57:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626183004/20001
3 years, 11 months ago (2017-01-13 00:57:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626183004/40001
3 years, 11 months ago (2017-01-13 02:10:52 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:50:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/198405bd55b43aa21b7d76e4188f...

Powered by Google App Engine
This is Rietveld 408576698