Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
index d85780fc5314d70a4c847fe33fa65b381d15f82b..ad85a749d4b751ef9303348763b0ad10cd0fc639 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
@@ -31,9 +31,10 @@
#ifndef RemoteWindowProxy_h
#define RemoteWindowProxy_h
+#include <v8.h>
#include "bindings/core/v8/DOMWrapperWorld.h"
+#include "bindings/core/v8/WindowProxy.h"
#include "core/frame/RemoteFrame.h"
-#include <v8.h>
namespace blink {
@@ -42,7 +43,6 @@ class RemoteWindowProxy final : public WindowProxy {
public:
static RemoteWindowProxy* create(v8::Isolate* isolate,
RemoteFrame& frame,
-
RefPtr<DOMWrapperWorld> world) {
return new RemoteWindowProxy(isolate, frame, std::move(world));
}
@@ -58,6 +58,8 @@ class RemoteWindowProxy final : public WindowProxy {
// prototype chain do not get fully initialized yet, e.g. the window
// wrapper is not yet associated with the native DOMWindow object.
void createContext();
+
+ void setupWindowPrototypeChain();
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698