Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2626183003: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef RemoteWindowProxy_h 31 #ifndef RemoteWindowProxy_h
32 #define RemoteWindowProxy_h 32 #define RemoteWindowProxy_h
33 33
34 #include <v8.h>
34 #include "bindings/core/v8/DOMWrapperWorld.h" 35 #include "bindings/core/v8/DOMWrapperWorld.h"
36 #include "bindings/core/v8/WindowProxy.h"
35 #include "core/frame/RemoteFrame.h" 37 #include "core/frame/RemoteFrame.h"
36 #include <v8.h>
37 38
38 namespace blink { 39 namespace blink {
39 40
40 // Subclass of WindowProxy that only handles RemoteFrame. 41 // Subclass of WindowProxy that only handles RemoteFrame.
41 class RemoteWindowProxy final : public WindowProxy { 42 class RemoteWindowProxy final : public WindowProxy {
42 public: 43 public:
43 static RemoteWindowProxy* create(v8::Isolate* isolate, 44 static RemoteWindowProxy* create(v8::Isolate* isolate,
44 RemoteFrame& frame, 45 RemoteFrame& frame,
45
46 RefPtr<DOMWrapperWorld> world) { 46 RefPtr<DOMWrapperWorld> world) {
47 return new RemoteWindowProxy(isolate, frame, std::move(world)); 47 return new RemoteWindowProxy(isolate, frame, std::move(world));
48 } 48 }
49 49
50 private: 50 private:
51 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>); 51 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);
52 52
53 void initialize() override; 53 void initialize() override;
54 void disposeContext(GlobalDetachmentBehavior) override; 54 void disposeContext(GlobalDetachmentBehavior) override;
55 55
56 // Creates a new v8::Context with the window wrapper object as the global 56 // Creates a new v8::Context with the window wrapper object as the global
57 // object (aka the inner global). Note that the window wrapper and its 57 // object (aka the inner global). Note that the window wrapper and its
58 // prototype chain do not get fully initialized yet, e.g. the window 58 // prototype chain do not get fully initialized yet, e.g. the window
59 // wrapper is not yet associated with the native DOMWindow object. 59 // wrapper is not yet associated with the native DOMWindow object.
60 void createContext(); 60 void createContext();
61
62 void setupWindowPrototypeChain();
61 }; 63 };
62 64
63 } // namespace blink 65 } // namespace blink
64 66
65 #endif // RemoteWindowProxy_h 67 #endif // RemoteWindowProxy_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698