Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: third_party/WebKit/Source/devtools/BUILD.gn

Issue 2626173002: DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index 40ed53a3e8a9d80e20f6768ea8efeda33450beaf..203d14bce00018b797b961a7a0ba19ab1c0a2774 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -235,6 +235,7 @@ all_devtools_files = [
"front_end/gonzales/gonzales-scss.js",
"front_end/gonzales/module.json",
"front_end/gonzales/SCSSParser.js",
+ "front_end/heap_snapshot_model/HeapSnapshotModel.js",
pfeldman 2017/01/11 23:01:42 it needs to have a module.json
chenwilliam 2017/01/11 23:41:59 done. I added it for all the new modules I made re
"front_end/heap_snapshot_worker.js",
"front_end/heap_snapshot_worker.json",
"front_end/heap_snapshot_worker/AllocationProfile.js",
@@ -350,7 +351,6 @@ all_devtools_files = [
"front_end/profiler/CPUProfileView.js",
"front_end/profiler/heapProfiler.css",
"front_end/profiler/HeapProfileView.js",
- "front_end/profiler/HeapSnapshotCommon.js",
"front_end/profiler/HeapSnapshotDataGrids.js",
"front_end/profiler/HeapSnapshotGridNodes.js",
"front_end/profiler/HeapSnapshotProxy.js",
@@ -801,6 +801,7 @@ generated_resources = [
"$resources_out_dir/devices/devices_module.js",
"$resources_out_dir/diff/diff_module.js",
"$resources_out_dir/elements/elements_module.js",
+ "$resources_out_dir/heap_snapshot_model/heap_snapshot_model_module.js",
"$resources_out_dir/inline_editor/inline_editor_module.js",
"$resources_out_dir/layer_viewer/layer_viewer_module.js",
"$resources_out_dir/layers/layers_module.js",

Powered by Google App Engine
This is Rietveld 408576698