Add more criteria to wait until keyboard appears.

ios/chrome/browser/web/browsing_egtest.mm

Index: ios/chrome/browser/web/browsing_egtest.mm
diff --git a/ios/chrome/browser/web/browsing_egtest.mm b/ios/chrome/browser/web/browsing_egtest.mm
index d7cbd57734b00bafedfa7a0ca6045e22c40aa1cf..367a9d8600ac281ea58a04a629251f37d856e22c 100644
--- a/ios/chrome/browser/web/browsing_egtest.mm
+++ b/ios/chrome/browser/web/browsing_egtest.mm
@@ -621,8 +621,9 @@ id<GREYMatcher> tabWithTitle(const std::string& tab_title) {
       conditionWithName:@"Wait for the keyboard to show up."
                   block:^BOOL {
                     NSError* error = nil;
-                    [[EarlGrey
-                        selectElementWithMatcher:grey_accessibilityID(@"Go")]
+                    id<GREYMatcher> keyboardGoButton = grey_allOf(

[Eugene But (OOO till 7-30), 2017/01/11 22:15:12]

Should this be a function instead of local variable?

[Eugene But (OOO till 7-30), 2017/01/11 22:15:12]

s/keyboardGoButton/keyboardGoButtonMatcher

[gchatz, 2017/01/11 22:28:41]

I moved it to a method in case other places that interact with a keyboard in
this file need it. 

[gchatz, 2017/01/11 22:28:41]

Done with method. 

+                        grey_accessibilityID(@"Go"), grey_interactable(), nil);
+                    [[EarlGrey selectElementWithMatcher:keyboardGoButton]
                         assertWithMatcher:grey_notNil()
                                     error:&error];
                     return (error == nil);