Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2626113002: Query the certificate size with CRYPTO_BUFFER in SSLClientSessionCache. (Closed)

Created:
3 years, 11 months ago by davidben
Modified:
3 years, 11 months ago
Reviewers:
svaldez
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Query the certificate size with CRYPTO_BUFFER in SSLClientSessionCache. This removes the access to x509_chain in Chromium which crept in. BUG=671420 Review-Url: https://codereview.chromium.org/2626113002 Cr-Commit-Position: refs/heads/master@{#443050} Committed: https://chromium.googlesource.com/chromium/src/+/b8c51582342eecea141ffaf98e90561670f1d491

Patch Set 1 #

Patch Set 2 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M net/ssl/ssl_client_session_cache.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
davidben
3 years, 11 months ago (2017-01-11 18:01:00 UTC) #5
svaldez
lgtm
3 years, 11 months ago (2017-01-11 18:02:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626113002/20001
3 years, 11 months ago (2017-01-11 19:33:29 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:18:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8c51582342eecea141ffaf98e90...

Powered by Google App Engine
This is Rietveld 408576698