[i18n] browser help, i18n-content to $i18n{}

[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626083005
Cr-Commit-Position: refs/heads/master@{#443140}
Committed: https://chromium.googlesource.com/chromium/src/+/73fbd9b3b88c3f8b73230861924e6e680231fcbf

[dschuyler, 2017-01-11 23:58:24]

Description was changed from

==========
[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
==========

to

==========
[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-01-11 23:58:26]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-01-12 00:04:08]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2017-01-12 00:47:42]

lgtm

[commit-bot: I haz the power, 2017-01-12 01:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:42:39]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-01-12 02:05:42]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:51:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484186742070140, "parent_rev":
"bf104bd8baf5e73b71c82ba60249cb778b8db099", "commit_rev":
"73fbd9b3b88c3f8b73230861924e6e680231fcbf"}

[commit-bot: I haz the power, 2017-01-12 03:52:35]

Description was changed from

==========
[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[i18n] browser help, i18n-content to $i18n{}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626083005
Cr-Commit-Position: refs/heads/master@{#443140}
Committed:
https://chromium.googlesource.com/chromium/src/+/73fbd9b3b88c3f8b73230861924e...
==========

[commit-bot: I haz the power, 2017-01-12 03:52:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73fbd9b3b88c3f8b73230861924e...

[Dan Beam, 2017-01-13 18:36:01]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-01-13 18:36:02]

it's probably a better use of your time to work on the replacement to this UI
(i.e. new settings) than change the deprecated version we hope to replace in the
upcoming milestone

[chromium-reviews, 2017-01-13 19:12:27]

I think we've been almost replacing it for over a year :) It wasn't a lot
of effort to run a conversion script.

On Fri, Jan 13, 2017 at 10:36 AM, <dbeam@chromium.org> wrote:

> it's probably a better use of your time to work on the replacement to this
> UI
> (i.e. new settings) than change the deprecated version we hope to replace
> in the
> upcoming milestone
>
> https://codereview.chromium.org/2626083005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Wez, 2017-02-07 19:23:57]

wez@chromium.org changed reviewers:
+ wez@chromium.org

[Wez, 2017-02-07 19:23:57]

Hallo dbeam@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective rubber-stamp review from you:
	chrome/browser/resources/help/channel_change_page.html
	chrome/browser/resources/help/help.html
	chrome/browser/resources/help/help_content.html
	chrome/browser/resources/help/help_page.html
Thanks,
Wez