Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2626073006: Add Finch testing variations for search geolocation disclosure. (Closed)

Created:
3 years, 11 months ago by benwells
Modified:
3 years, 11 months ago
Reviewers:
dominickn, rkaplow
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, raymes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Finch testing variations for search geolocation disclosure. BUG=661011 Review-Url: https://codereview.chromium.org/2626073006 Cr-Commit-Position: refs/heads/master@{#443447} Committed: https://chromium.googlesource.com/chromium/src/+/00cd9cf3c6e1b0dbc637090df6bf567e043c3c5b

Patch Set 1 #

Patch Set 2 : oops #

Total comments: 2

Patch Set 3 : Remove all but first experiments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
benwells
dom for local sanity check
3 years, 11 months ago (2017-01-12 04:32:15 UTC) #2
dominickn
lgtm FYI: only the first config will be run on the perf test bots, so ...
3 years, 11 months ago (2017-01-12 04:45:06 UTC) #3
benwells
On 2017/01/12 04:45:06, dominickn wrote: > lgtm > > FYI: only the first config will ...
3 years, 11 months ago (2017-01-12 04:58:08 UTC) #4
benwells
+rkaplow for owners review
3 years, 11 months ago (2017-01-12 04:58:30 UTC) #6
benwells
+cc raymes
3 years, 11 months ago (2017-01-12 07:22:42 UTC) #8
rkaplow
https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fieldtrial_testing_config.json#newcode2062 testing/variations/fieldtrial_testing_config.json:2062: "experiments": [ we only support one experiment tested in ...
3 years, 11 months ago (2017-01-12 16:30:36 UTC) #9
rkaplow
lgtm
3 years, 11 months ago (2017-01-12 16:45:17 UTC) #10
benwells
https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fieldtrial_testing_config.json#newcode2062 testing/variations/fieldtrial_testing_config.json:2062: "experiments": [ On 2017/01/12 16:30:36, rkaplow wrote: > we ...
3 years, 11 months ago (2017-01-12 23:29:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626073006/40001
3 years, 11 months ago (2017-01-12 23:30:54 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:46:21 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/00cd9cf3c6e1b0dbc637090df6bf...

Powered by Google App Engine
This is Rietveld 408576698