|
|
Chromium Code Reviews
DescriptionAdd Finch testing variations for search geolocation disclosure.
BUG=661011
Review-Url: https://codereview.chromium.org/2626073006
Cr-Commit-Position: refs/heads/master@{#443447}
Committed: https://chromium.googlesource.com/chromium/src/+/00cd9cf3c6e1b0dbc637090df6bf567e043c3c5b
Patch Set 1 #Patch Set 2 : oops #
Total comments: 2
Patch Set 3 : Remove all but first experiments #Messages
Total messages: 19 (9 generated)
benwells@chromium.org changed reviewers: + dominickn@chromium.org
dom for local sanity check
lgtm FYI: only the first config will be run on the perf test bots, so make sure it's the one most likely to launch.
On 2017/01/12 04:45:06, dominickn wrote: > lgtm > > FYI: only the first config will be run on the perf test bots, so make sure it's > the one most likely to launch. Yep, it's the one we'll probably go with.
benwells@chromium.org changed reviewers: + rkaplow@chromium.org
+rkaplow for owners review
Description was changed from ========== Add Finch testing variations for search geolocation disclosure. BUG=661011 ========== to ========== Add Finch testing variations for search geolocation disclosure. BUG=661011 ==========
+cc raymes
https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fiel... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fiel... testing/variations/fieldtrial_testing_config.json:2062: "experiments": [ we only support one experiment tested in the test bots so we recommend usually just having one which you want to get tested. That group should be the experiment group you think is most likely to be released.
lgtm
https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fiel... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2626073006/diff/20001/testing/variations/fiel... testing/variations/fieldtrial_testing_config.json:2062: "experiments": [ On 2017/01/12 16:30:36, rkaplow wrote: > we only support one experiment tested in the test bots so we recommend usually > just having one which you want to get tested. That group should be the > experiment group you think is most likely to be released. Ah, OK. I've removed all but the first one, which is the one we think will be released.
The CQ bit was checked by benwells@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dominickn@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2626073006/#ps40001 (title: "Remove all but first experiments")
The CQ bit was unchecked by benwells@chromium.org
The CQ bit was checked by benwells@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484263790646990,
"parent_rev": "4ebe01d1636b1ed0b258584b2485470646f7aec9", "commit_rev":
"00cd9cf3c6e1b0dbc637090df6bf567e043c3c5b"}
Message was sent while issue was closed.
Description was changed from ========== Add Finch testing variations for search geolocation disclosure. BUG=661011 ========== to ========== Add Finch testing variations for search geolocation disclosure. BUG=661011 Review-Url: https://codereview.chromium.org/2626073006 Cr-Commit-Position: refs/heads/master@{#443447} Committed: https://chromium.googlesource.com/chromium/src/+/00cd9cf3c6e1b0dbc637090df6bf... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/00cd9cf3c6e1b0dbc637090df6bf... |
