Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2626073005: Use observed pointers in CPDFSDK_AnnotIterator. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use observed pointers in CPDFSDK_AnnotIterator. Rename to CPDFSDK_AnnotIteration, as it is now an ordered set of annots, and not the iterator itself. Review-Url: https://codereview.chromium.org/2626073005 Committed: https://pdfium.googlesource.com/pdfium/+/d805eec52f6ac574918748c4270873e7e5cde596

Patch Set 1 #

Patch Set 2 : rename #

Total comments: 1

Patch Set 3 : rename, part 2 #

Patch Set 4 : negation of condition #

Total comments: 4

Patch Set 5 : logic botch, copyright year #

Total comments: 2

Patch Set 6 : remove local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -120 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
A fpdfsdk/cpdfsdk_annotiteration.h View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
A fpdfsdk/cpdfsdk_annotiteration.cpp View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
M fpdfsdk/cpdfsdk_annotiterator.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M fpdfsdk/cpdfsdk_annotiterator.cpp View 1 1 chunk +0 lines, -54 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 2 2 chunks +14 lines, -18 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 5 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Tom Sepez
https://codereview.chromium.org/2626073005/diff/20001/fpdfsdk/cpdfsdk_annotiteration.h File fpdfsdk/cpdfsdk_annotiteration.h (right): https://codereview.chromium.org/2626073005/diff/20001/fpdfsdk/cpdfsdk_annotiteration.h#newcode1 fpdfsdk/cpdfsdk_annotiteration.h:1: // Copyright 2016 PDFium Authors. All rights reserved. NOTE: ...
3 years, 11 months ago (2017-01-11 20:59:43 UTC) #2
Tom Sepez
Dan, for review.
3 years, 11 months ago (2017-01-11 21:00:50 UTC) #6
dsinclair
https://codereview.chromium.org/2626073005/diff/60001/fpdfsdk/cpdfsdk_annotiteration.cpp File fpdfsdk/cpdfsdk_annotiteration.cpp (right): https://codereview.chromium.org/2626073005/diff/60001/fpdfsdk/cpdfsdk_annotiteration.cpp#newcode1 fpdfsdk/cpdfsdk_annotiteration.cpp:1: // Copyright 2016 PDFium Authors. All rights reserved. 2017 ...
3 years, 11 months ago (2017-01-11 21:22:53 UTC) #7
Tom Sepez
Argh, you're right. https://codereview.chromium.org/2626073005/diff/60001/fpdfsdk/cpdfsdk_annotiteration.cpp File fpdfsdk/cpdfsdk_annotiteration.cpp (right): https://codereview.chromium.org/2626073005/diff/60001/fpdfsdk/cpdfsdk_annotiteration.cpp#newcode28 fpdfsdk/cpdfsdk_annotiteration.cpp:28: std::swap(*it, *copiedList.begin()); On 2017/01/11 21:22:52, dsinclair ...
3 years, 11 months ago (2017-01-11 21:34:26 UTC) #8
dsinclair
lgtm w/ question. https://codereview.chromium.org/2626073005/diff/80001/fpdfsdk/cpdfsdk_annotiteration.cpp File fpdfsdk/cpdfsdk_annotiteration.cpp (right): https://codereview.chromium.org/2626073005/diff/80001/fpdfsdk/cpdfsdk_annotiteration.cpp#newcode28 fpdfsdk/cpdfsdk_annotiteration.cpp:28: CPDFSDK_Annot* pSaved = *it; Is this ...
3 years, 11 months ago (2017-01-11 21:44:24 UTC) #9
Tom Sepez
https://codereview.chromium.org/2626073005/diff/80001/fpdfsdk/cpdfsdk_annotiteration.cpp File fpdfsdk/cpdfsdk_annotiteration.cpp (right): https://codereview.chromium.org/2626073005/diff/80001/fpdfsdk/cpdfsdk_annotiteration.cpp#newcode28 fpdfsdk/cpdfsdk_annotiteration.cpp:28: CPDFSDK_Annot* pSaved = *it; On 2017/01/11 21:44:24, dsinclair wrote: ...
3 years, 11 months ago (2017-01-11 21:48:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626073005/100001
3 years, 11 months ago (2017-01-11 21:49:03 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:03:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/d805eec52f6ac574918748c4270873e7e5cd...

Powered by Google App Engine
This is Rietveld 408576698