Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2626043005: X87: [debugger] infrastructure for side-effect-free debug-evaluate. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [debugger] infrastructure for side-effect-free debug-evaluate. port aa75904e3c2072f6b0d6ed92f75d1fb729d7cefa (r42270) original commit message: BUG= Review-Url: https://codereview.chromium.org/2626043005 Cr-Commit-Position: refs/heads/master@{#42352} Committed: https://chromium.googlesource.com/v8/v8/+/4a03e19fc106735c3beb693314a8a8f76146c5c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/builtins/x87/builtins-x87.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/debug/x87/debug-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 4 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-13 08:47:53 UTC) #2
chunyang.dai
On 2017/01/13 08:47:53, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-16 02:33:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626043005/1
3 years, 11 months ago (2017-01-16 02:55:11 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 03:15:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4a03e19fc106735c3beb693314a8a8f7614...

Powered by Google App Engine
This is Rietveld 408576698