Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2626043004: PlzNavigate: ensure POST submissions create navigation entries (Closed)

Created:
3 years, 11 months ago by clamy
Modified:
3 years, 11 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: ensure POST submissions create navigation entries This CL fixes an issue in PlzNavigate where a POST navigation that resulted in a navigation to the current URL was wrongly categorized by Blink as a reload and would not create a NavigationEntry. BUG=608372 Review-Url: https://codereview.chromium.org/2626043004 Cr-Commit-Position: refs/heads/master@{#444709} Committed: https://chromium.googlesource.com/chromium/src/+/4b3e2a7606da6f4d23fe6e83ece19aceaced85c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
clamy
@japhet: PTAL
3 years, 11 months ago (2017-01-12 14:28:04 UTC) #7
clamy
@japhet: friendly ping :).
3 years, 11 months ago (2017-01-18 13:03:30 UTC) #8
Nate Chapin
lgtm
3 years, 11 months ago (2017-01-18 22:06:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626043004/1
3 years, 11 months ago (2017-01-19 10:53:50 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 12:14:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b3e2a7606da6f4d23fe6e83ece1...

Powered by Google App Engine
This is Rietveld 408576698