Passing FrameSinkId to WindowCompositorFrameSink

Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.

BUG=676384
Review-Url: https://codereview.chromium.org/2626023007
Cr-Commit-Position: refs/heads/master@{#443716}
Committed: https://chromium.googlesource.com/chromium/src/+/d5db25071f9cdb10c402e2131f60a46b0c557b74

[Saman Sami, 2017-01-13 19:29:47]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 19:30:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-13 19:32:01]

Description was changed from

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.
==========

to

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.
==========

[Saman Sami, 2017-01-13 19:32:01]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-01-13 19:33:14]

samans@chromium.org changed reviewers:
+ sadrul@chromium.org, sky@chromium.org

[Saman Sami, 2017-01-13 19:36:55]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 19:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-13 19:39:05]

Please update services/ui/public/cpp/window_compositor_frame_sink.h too! Thanks!

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.cc (right):

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:82: cc::FrameSinkId frame_sink_id(server_id(),
0);
No point in having a member variable

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:85: frame_sink_id, std::move(context_provider),
gpu_memory_buffer_manager,
cc::FrameSinkId(server_id(), 0)

[Fady Samuel, 2017-01-13 19:39:05]

Please update services/ui/public/cpp/window_compositor_frame_sink.h too! Thanks!

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.cc (right):

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:82: cc::FrameSinkId frame_sink_id(server_id(),
0);
No point in having a member variable

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:85: frame_sink_id, std::move(context_provider),
gpu_memory_buffer_manager,
cc::FrameSinkId(server_id(), 0)

[Saman Sami, 2017-01-13 19:41:22]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-13 19:41:52]

PTAL

sky, sadrul: Please review all files.

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.cc (right):

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:82: cc::FrameSinkId frame_sink_id(server_id(),
0);
On 2017/01/13 19:39:05, Fady Samuel wrote:
> No point in having a member variable

Done.

https://codereview.chromium.org/2626023007/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.cc:85: frame_sink_id, std::move(context_provider),
gpu_memory_buffer_manager,
On 2017/01/13 19:39:05, Fady Samuel wrote:
> cc::FrameSinkId(server_id(), 0)

Done.

[commit-bot: I haz the power, 2017-01-13 19:42:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-13 20:04:57]

Please add a BUG line.

[Fady Samuel, 2017-01-13 20:06:11]

Please update services/ui/public/cpp/window_compositor_frame_sink.h too! Thanks!
Publish all my drafts

[Saman Sami, 2017-01-13 20:06:12]

Description was changed from

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.
==========

to

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.

BUG=676384
==========

[Fady Samuel, 2017-01-13 20:07:06]

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:16: cc::FrameSinkId frame_sink_id,
const cc::FrameSinkId&

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:83: cc::FrameSinkId frame_sink_id,
const cc::FrameSinkId&

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.h (right):

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:27: cc::FrameSinkId frame_sink_id,
const cc::FrameSinkId&

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:42: cc::FrameSinkId frame_sink_id,
const cc::FrameSinkId&

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:67: cc::FrameSinkId frame_sink_id_;
const cc::FrameSinkId

[sky, 2017-01-13 20:37:24]

LGTM once you address comments

[Saman Sami, 2017-01-13 21:01:15]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 21:02:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-13 21:05:40]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 21:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-13 21:12:06]

lgtm if all the tests are passing.

[Saman Sami, 2017-01-13 21:13:25]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-13 21:14:14]

samans@chromium.org changed reviewers:
+ jam@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-13 21:14:49]

PTAL

jam@: Please review content/

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.h (right):

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:27: cc::FrameSinkId frame_sink_id,
On 2017/01/13 20:07:06, Fady Samuel wrote:
> const cc::FrameSinkId&

Done.

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:42: cc::FrameSinkId frame_sink_id,
On 2017/01/13 20:07:06, Fady Samuel wrote:
> const cc::FrameSinkId&

Done.

https://codereview.chromium.org/2626023007/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.h:67: cc::FrameSinkId frame_sink_id_;
On 2017/01/13 20:07:06, Fady Samuel wrote:
> const cc::FrameSinkId

Done.

[Saman Sami, 2017-01-13 21:31:50]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 21:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 22:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 22:43:41]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-13 23:09:26]

lgtm

[Saman Sami, 2017-01-13 23:10:57]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-13 23:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2626023007/#ps2 (title:
"c")

[commit-bot: I haz the power, 2017-01-13 23:11:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:18:32]

CQ is committing da patch.

Bot data: {"patchset_id": 2, "attempt_start_ts": 1484349057517350, "parent_rev":
"f39002f13c4ceab02883b053607fefe9d585db54", "commit_rev":
"d5db25071f9cdb10c402e2131f60a46b0c557b74"}

[commit-bot: I haz the power, 2017-01-13 23:19:04]

Description was changed from

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.

BUG=676384
==========

to

==========
Passing FrameSinkId to WindowCompositorFrameSink

WindowCompositorFrameSink needs to know its surface id to add and remove
references, which means it should know its frame sink id.

BUG=676384

Review-Url: https://codereview.chromium.org/2626023007
Cr-Commit-Position: refs/heads/master@{#443716}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5db25071f9cdb10c402e2131f60...
==========

[commit-bot: I haz the power, 2017-01-13 23:19:07]

Committed patchset #7 (id:2) as
https://chromium.googlesource.com/chromium/src/+/d5db25071f9cdb10c402e2131f60...