Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2626023006: Check that render-frame is valid before returning audio params in Blink. (Closed)

Created:
3 years, 11 months ago by Guido Urdaneta
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that render-frame is valid before returning audio params in Blink. Return reasonable parameters if the render_frame is not valid instead of crashing. BUG=678927 Review-Url: https://codereview.chromium.org/2626023006 Cr-Commit-Position: refs/heads/master@{#443676} Committed: https://chromium.googlesource.com/chromium/src/+/44bfa4bd4fb0143a64d5748d68b17bbedee4caaa

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A content/renderer/blink_platform_audio_hardware_browsertest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Guido Urdaneta
Hi, PTAL.
3 years, 11 months ago (2017-01-13 09:32:19 UTC) #4
jochen (gone - plz use gerrit)
can you add a test please?
3 years, 11 months ago (2017-01-13 14:20:16 UTC) #7
Guido Urdaneta
On 2017/01/13 14:20:16, jochen wrote: > can you add a test please? jochen@: I couldn't ...
3 years, 11 months ago (2017-01-13 18:25:04 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-13 18:52:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626023006/20001
3 years, 11 months ago (2017-01-13 18:53:42 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:32:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44bfa4bd4fb0143a64d5748d68b1...

Powered by Google App Engine
This is Rietveld 408576698