Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2626023003: Use GetProfileName() for logging VideoCodecProfile strings. (Closed)

Created:
3 years, 11 months ago by jam39
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GetProfileName() for logging VideoCodecProfile strings. BUG=676022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626023003 Cr-Commit-Position: refs/heads/master@{#444738} Committed: https://chromium.googlesource.com/chromium/src/+/9a44ab189f977553b42b9d7706628b959289308a

Patch Set 1 #

Patch Set 2 : Use GetProfileName() for logging VideoCodecProfile strings. #

Patch Set 3 : Use GetProfileName() for logging VideoCodecProfile strings. #

Total comments: 1

Patch Set 4 : Don't use GetProfileName() for H.264 VideoCodecProfile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_encode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M media/gpu/vaapi_video_encode_accelerator.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (18 generated)
jam39
On 2017/01/11 16:28:28, jam39 wrote: > mailto:jem456.vasishta@gmail.com changed reviewers: > + mailto:wuchengli@chromium.org PTAL
3 years, 11 months ago (2017-01-12 12:29:15 UTC) #5
mcasas
changes lgtm (you still needs owners though)
3 years, 11 months ago (2017-01-12 18:31:13 UTC) #6
Pawel Osciak
lgtm
3 years, 11 months ago (2017-01-16 02:15:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626023003/1
3 years, 11 months ago (2017-01-16 10:51:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/342648)
3 years, 11 months ago (2017-01-16 10:58:04 UTC) #11
jam39
On 2017/01/16 10:58:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-17 15:30:57 UTC) #13
sandersd (OOO until July 31)
https://codereview.chromium.org/2626023003/diff/40001/media/gpu/vaapi_video_decode_accelerator.cc File media/gpu/vaapi_video_decode_accelerator.cc (right): https://codereview.chromium.org/2626023003/diff/40001/media/gpu/vaapi_video_decode_accelerator.cc#newcode1749 media/gpu/vaapi_video_decode_accelerator.cc:1749: << GetProfileName((VideoCodecProfile)frame_hdr->profile); I've not checked all of the VAAPI ...
3 years, 11 months ago (2017-01-17 21:29:00 UTC) #18
jam39
PTAL
3 years, 11 months ago (2017-01-18 16:01:40 UTC) #19
sandersd (OOO until July 31)
lgtm
3 years, 11 months ago (2017-01-18 19:36:29 UTC) #21
wolenetz
lgtm
3 years, 11 months ago (2017-01-18 20:14:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626023003/60001
3 years, 11 months ago (2017-01-18 23:51:32 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/6466)
3 years, 11 months ago (2017-01-19 01:26:55 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626023003/60001
3 years, 11 months ago (2017-01-19 14:47:18 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 15:26:53 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9a44ab189f977553b42b9d770662...

Powered by Google App Engine
This is Rietveld 408576698