Fix invalid URIs generated using Uri constructor with clever paths.

Fix invalid URIs generated using Uri constructor with clever paths.

Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/d3a839fb84c744fb77bfff67d0d39df99cfa6404
Committed: https://github.com/dart-lang/sdk/commit/dab2d0efb89381334e355ea46d8e55d8280af36e

[Lasse Reichstein Nielsen, 2017-01-12 14:00:50]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-01-12 16:05:49]

LGTM.

https://codereview.chromium.org/2626013004/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2626013004/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:1473: path = _normalizeRelativePath(path,
scheme.isNotEmpty || host != null);
I generally assign boolean variables to locals first:
bool allowScheme = scheme.isNotEmpty || host != null;
path = _normalizeRelativePath(path, allowScheme);

There is no verification that the names match, but if they do, then the reader
has a better understanding of what is passed in.

https://codereview.chromium.org/2626013004/diff/1/tests/corelib/uri_test.dart
File tests/corelib/uri_test.dart (right):

https://codereview.chromium.org/2626013004/diff/1/tests/corelib/uri_test.dart...
tests/corelib/uri_test.dart:768: // This is an invalid pat for a URI reference
with no authority or scheme
path

[Lasse Reichstein Nielsen, 2017-01-13 08:38:12]

Description was changed from

==========
Fix invalid URIs generated using Uri constructor with clever paths.

Fixes issue #28359
BUG= http://dartbug.com/28359
==========

to

==========
Fix invalid URIs generated using Uri constructor with clever paths.

Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d3a839fb84c744fb77bfff67d0d39df99cfa6404
==========

[Lasse Reichstein Nielsen, 2017-01-13 08:38:17]

Committed patchset #1 (id:1) manually as
d3a839fb84c744fb77bfff67d0d39df99cfa6404 (presubmit successful).

[Lasse Reichstein Nielsen, 2017-01-16 08:16:10]

Description was changed from

==========
Fix invalid URIs generated using Uri constructor with clever paths.

Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d3a839fb84c744fb77bfff67d0d39df99cfa6404
==========

to

==========
Fix invalid URIs generated using Uri constructor with clever paths.

Fixes issue #28359
BUG= http://dartbug.com/28359
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d3a839fb84c744fb77bfff67d0d39df99cfa6404
Committed:
https://github.com/dart-lang/sdk/commit/dab2d0efb89381334e355ea46d8e55d8280af36e
==========

[Lasse Reichstein Nielsen, 2017-01-16 08:16:11]

Committed patchset #1 (id:1) manually as
dab2d0efb89381334e355ea46d8e55d8280af36e (presubmit successful).

[Lasse Reichstein Nielsen, 2017-01-16 08:17:23]

https://codereview.chromium.org/2626013004/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2626013004/diff/1/sdk/lib/core/uri.dart#newco...
sdk/lib/core/uri.dart:1473: path = _normalizeRelativePath(path,
scheme.isNotEmpty || host != null);
On 2017/01/12 16:05:49, floitsch wrote:
> I generally assign boolean variables to locals first:
> bool allowScheme = scheme.isNotEmpty || host != null;
> path = _normalizeRelativePath(path, allowScheme);
> 
> There is no verification that the names match, but if they do, then the reader
> has a better understanding of what is passed in.

Done.

https://codereview.chromium.org/2626013004/diff/1/tests/corelib/uri_test.dart
File tests/corelib/uri_test.dart (right):

https://codereview.chromium.org/2626013004/diff/1/tests/corelib/uri_test.dart...
tests/corelib/uri_test.dart:768: // This is an invalid pat for a URI reference
with no authority or scheme
On 2017/01/12 16:05:49, floitsch wrote:
> path

Done.