Fix invalid URIs generated using Uri constructor with clever paths.

tests/corelib/uri_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library uriTest;
 
 import "package:expect/expect.dart";
 import 'dart:convert';
 
 testUri(String uriText, bool isAbsolute) {
@@ skipping 737 matching lines @@
   Expect.listEquals(["43", "38"], params["y"]);
 
   // Test replacing with empty strings.
   uri = Uri.parse("s://a:1/b/c?d#e");
   Expect.equals("s://a:1/b/c?d#", uri.replace(fragment: "").toString());
   Expect.equals("s://a:1/b/c?#e", uri.replace(query: "").toString());
   Expect.equals("s://a:1?d#e", uri.replace(path: "").toString());
   Expect.equals("s://:1/b/c?d#e", uri.replace(host: "").toString());
 }
 
+void testRegression28359() {
+  var uri = new Uri(path: "//");
+  // This is an invalid path for a URI reference with no authority
+  // since it looks like an authority.
+  // Normalized to have an authority.
+  Expect.equals("////", "$uri");
+  Expect.equals("//", uri.path);
+  Expect.isTrue(uri.hasAuthority, "$uri has authority");
+
+  uri = new Uri(path: "file:///wat");
+  // This is an invalid pat for a URI reference with no authority or scheme

[floitsch, 2017/01/12 16:05:49]

path

[Lasse Reichstein Nielsen, 2017/01/16 08:17:23]

Done.

+  // since the path looks like it starts with a scheme.
+  // Normalized by escaping the ":".
+  Expect.equals("file%3A///wat", uri.path);
+  Expect.equals("file%3A///wat", "$uri");
+  Expect.isFalse(uri.hasAuthority);
+  Expect.isFalse(uri.hasScheme);
+}
+
 main() {
   testUri("http:", true);
   testUri("file:///", true);
   testUri("file", false);
   testUri("http://user@example.com:8080/fisk?query=89&hest=silas", true);
   testUri("http://user@example.com:8080/fisk?query=89&hest=silas#fragment",
           false);
   Expect.stringEquals("http://user@example.com/a/b/c?query#fragment",
                       new Uri(
                           scheme: "http",
@@ skipping 146 matching lines @@
 
   // Invalid URI - : and @ is swapped, port ("host") should be numeric.
   Expect.throws(
       () => Uri.parse("file://user@password:host/path"),
       (e) => e is FormatException);
 
   testValidCharacters();
   testInvalidUrls();
   testNormalization();
   testReplace();
+  testRegression28359();
 }
 
 String dump(Uri uri) {
   return "URI: $uri\n"
       "  Scheme:    ${uri.scheme} #${uri.scheme.length}\n"
       "  User-info: ${uri.userInfo} #${uri.userInfo.length}\n"
       "  Host:      ${uri.host} #${uri.host.length}\n"
       "  Port:      ${uri.port}\n"
       "  Path:      ${uri.path} #${uri.path.length}\n"
       "  Query:     ${uri.query} #${uri.query.length}\n"
       "  Fragment:  ${uri.fragment} #${uri.fragment.length}\n";
 }