Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2626003004: [Signin iOS] Ensure SigninInteractionController displays signin errors. (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin iOS] Ensure SigninInteractionController displays signin errors. SigninInteractionController uses an AlertCoordinator to display potential sign-in errors, which requires the view controler to use to present the alert dialog. To ensure SigninInteractionController can always display correctly errors, the AlertCoordinator must be given the top most visible view controller (some errors are displayed before the sign-in screen is shown, and some are displayed on top of the sign-in screen). BUG=679809 Review-Url: https://codereview.chromium.org/2626003004 Cr-Commit-Position: refs/heads/master@{#443230} Committed: https://chromium.googlesource.com/chromium/src/+/6f9dd03c83e9a69b48a941b553fe255c68d401d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ios/chrome/browser/ui/authentication/signin_interaction_controller.mm View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bzanotti
Please take a look.
3 years, 11 months ago (2017-01-12 14:55:05 UTC) #2
lpromero
lgtm
3 years, 11 months ago (2017-01-12 14:58:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626003004/1
3 years, 11 months ago (2017-01-12 14:58:29 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 15:10:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f9dd03c83e9a69b48a941b553fe...

Powered by Google App Engine
This is Rietveld 408576698