Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2626003003: Implement multitest expectations. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M pkg/testing/lib/src/chain.dart View 5 chunks +19 lines, -8 lines 0 comments Download
M pkg/testing/lib/src/log.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/multitest.dart View 2 chunks +19 lines, -6 lines 3 comments Download
M pkg/testing/lib/src/test_description.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2624373003 Patch 1

Dependent Patchsets:

Issue 2627753005 Patch 20001

Messages

Total messages: 8 (3 generated)
ahe
3 years, 11 months ago (2017-01-12 12:13:43 UTC) #2
karlklose
LGTM https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multitest.dart File pkg/testing/lib/src/multitest.dart (right): https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multitest.dart#newcode24 pkg/testing/lib/src/multitest.dart:24: if (expectations.contains("dynamic type error")) return true; Is this ...
3 years, 11 months ago (2017-01-16 07:57:58 UTC) #3
ahe
Thank you, Karl! https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multitest.dart File pkg/testing/lib/src/multitest.dart (right): https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multitest.dart#newcode24 pkg/testing/lib/src/multitest.dart:24: if (expectations.contains("dynamic type error")) return true; ...
3 years, 11 months ago (2017-01-16 08:37:44 UTC) #5
ahe
Committed patchset #1 (id:1) manually as 99cec270159d8f5a58ffff3376d62174fa2c3771 (presubmit successful).
3 years, 11 months ago (2017-01-16 08:37:44 UTC) #6
ahe
3 years, 11 months ago (2017-01-18 11:25:31 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multite...
File pkg/testing/lib/src/multitest.dart (right):

https://codereview.chromium.org/2626003003/diff/1/pkg/testing/lib/src/multite...
pkg/testing/lib/src/multitest.dart:24: if (expectations.contains("dynamic type
error")) return true;
On 2017/01/16 08:37:44, ahe wrote:
> On 2017/01/16 07:57:58, karlklose wrote:
> > Is this annotation intended for strong mode? We did not have that before, or
> did
> > we?
> 
> Not sure. I assumed it was for checked mode. Perhaps I need to return false
> here?
> 
> I'll follow up on that.

Following up in CL 2641833002.

Powered by Google App Engine
This is Rietveld 408576698