Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2624373003: Move package:testing to SDK. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3089 lines, -5 lines) Patch
M DEPS View 3 chunks +0 lines, -5 lines 0 comments Download
A pkg/testing/README.md View 1 chunk +265 lines, -0 lines 0 comments Download
A pkg/testing/bin/run_tests.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/testing/bin/testing.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/testing/lib/dart_vm_suite.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/analyze.dart View 1 chunk +150 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/chain.dart View 1 chunk +330 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/discover.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/error_handling.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/log.dart View 1 chunk +164 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/multitest.dart View 1 chunk +124 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/run.dart View 1 chunk +229 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/run_tests.dart View 1 chunk +205 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/stdio_process.dart View 1 chunk +70 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/suite.dart View 1 chunk +84 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_dart/README.md View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_dart/path.dart View 1 chunk +311 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_dart/status_expression.dart View 1 chunk +314 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_dart/status_file_parser.dart View 1 chunk +341 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_description.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/test_root.dart View 1 chunk +104 lines, -0 lines 0 comments Download
A pkg/testing/lib/src/zone_helper.dart View 1 chunk +89 lines, -0 lines 0 comments Download
A pkg/testing/lib/testing.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/testing/test/dart_sdk_negative_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/testing/test/dart_vm_suite.status View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/testing/test/hello_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/testing/testing.json View 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2631503002 Patch 20001

Dependent Patchsets:

Issue 2626003003 Patch 1

Messages

Total messages: 5 (2 generated)
ahe
The files in pkg/testing are copied from https://github.com/peter-ahe-google/testing.git@aa421da7d0ca82f7b14546b6a87f2126504b7223 which you already have reviewed.
3 years, 11 months ago (2017-01-12 12:08:20 UTC) #2
karlklose
LGTM
3 years, 11 months ago (2017-01-16 07:55:30 UTC) #3
ahe
3 years, 11 months ago (2017-01-16 08:33:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b5fae56fcead3105af8c37833bf63055707004ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698