Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2626003002: Hook up new V8 use counters (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-11 12:49:42 UTC) #1
adamk
lgtm, but looks like this depends on https://codereview.chromium.org/2628863002/ so I guess it'll have to wait ...
3 years, 11 months ago (2017-01-11 17:38:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626003002/40001
3 years, 11 months ago (2017-01-13 08:29:16 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 10:16:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7ea6c64a7c1acde863cb5db1446...

Powered by Google App Engine
This is Rietveld 408576698