Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2625933007: [M56] DCHECK that full hash must be 32 bytes or 21 bytes long (Closed)

Created:
3 years, 11 months ago by vakh (use Gerrit instead)
Modified:
3 years, 11 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, vakh+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56] DCHECK that full hash must be 32 bytes or 21 bytes long Merges http://crrev.com/2614763002 to M56. NOTRY=true NOPRESUBMIT=true BUG=680346 Review-Url: https://codereview.chromium.org/2625933007 Cr-Commit-Position: refs/branch-heads/2924@{#756} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/e3ddcd882959d97b711ebb4c705de8c568acb7ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M components/safe_browsing_db/v4_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/v4_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_store_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
vakh (use Gerrit instead)
Please note that this CL hasn't been approved for Merge yet. See http://crbug.com/680346
3 years, 11 months ago (2017-01-12 21:22:07 UTC) #2
Nathan Parker
lgtm
3 years, 11 months ago (2017-01-12 23:21:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625933007/1
3 years, 11 months ago (2017-01-13 03:17:42 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:19:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3ddcd882959d97b711ebb4c705d...

Powered by Google App Engine
This is Rietveld 408576698