Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2625913002: Fix check for when symbols are out of date. (Closed)

Created:
3 years, 11 months ago by assareh
Modified:
3 years, 11 months ago
Reviewers:
phajdan, Michael Moss, mmoss
CC:
chromium-reviews, rkuroiwa1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix check for when symbols are out of date. Review-Url: https://codereview.chromium.org/2625913002 Cr-Commit-Position: refs/heads/master@{#443376} Committed: https://chromium.googlesource.com/chromium/src/+/48e8d5c92a0aea1db6d3ad5df0d9ad62b9de7b7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/dump_app_syms.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
assareh
3 years, 11 months ago (2017-01-11 19:54:45 UTC) #3
Michael Moss
lgtm
3 years, 11 months ago (2017-01-12 20:01:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625913002/1
3 years, 11 months ago (2017-01-12 21:44:22 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:55:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48e8d5c92a0aea1db6d3ad5df0d9...

Powered by Google App Engine
This is Rietveld 408576698