Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2625903003: Update scoped_ptr references to be unique_ptr in src/base comments. (Closed)

Created:
3 years, 11 months ago by scheib
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, grt+watch_chromium.org, robliao+watch_chromium.org, gavinp+memory_chromium.org, wfh+watch_chromium.org, gab+watch_chromium.org, mac-reviews_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update scoped_ptr references to be unique_ptr in src/base comments. BUG=554298 Review-Url: https://codereview.chromium.org/2625903003 Cr-Commit-Position: refs/heads/master@{#442862} Committed: https://chromium.googlesource.com/chromium/src/+/517357f8605f2e4b809931640b1c7ef2a0ce8b4e

Patch Set 1 #

Total comments: 1

Patch Set 2 : spelling fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M base/bind_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/leak_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/scoped_authorizationref.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/linked_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/scoped_vector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_glib.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_generic.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/task_scheduler/sequence_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_bstr.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_comptr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
scheib
3 years, 11 months ago (2017-01-11 04:16:13 UTC) #4
dcheng
LGTM with nit https://codereview.chromium.org/2625903003/diff/1/base/win/scoped_bstr.h File base/win/scoped_bstr.h (right): https://codereview.chromium.org/2625903003/diff/1/base/win/scoped_bstr.h#newcode21 base/win/scoped_bstr.h:21: // The class interface is based ...
3 years, 11 months ago (2017-01-11 04:42:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625903003/20001
3 years, 11 months ago (2017-01-11 05:55:37 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:41:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/517357f8605f2e4b809931640b1c...

Powered by Google App Engine
This is Rietveld 408576698