Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2625903002: Improve performance of HTMLElement::attributeChanged. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve performance of HTMLElement::attributeChanged. Call adjustedFocusedElementInTreeScope() only if the modified attribute can affect focusability. BUG=677446 Review-Url: https://codereview.chromium.org/2625903002 Cr-Commit-Position: refs/heads/master@{#442794} Committed: https://chromium.googlesource.com/chromium/src/+/ca7cf349eaf2714ed766e67827486b8417aa84b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
kochi@, would you review this please? Dromaeo.domcoreattr on macOS, 780 runs/sec -> 850 runs/sec
3 years, 11 months ago (2017-01-11 00:25:40 UTC) #4
kochi
lgtm
3 years, 11 months ago (2017-01-11 00:35:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625903002/1
3 years, 11 months ago (2017-01-11 02:23:35 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:13:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca7cf349eaf2714ed766e6782748...

Powered by Google App Engine
This is Rietveld 408576698