[deoptimizer] Insert more consistency checks.

[deoptimizer] Insert more consistency checks.

This is mainly to catch a crash that we see in Canary with escape
analysis on.

Review-Url: https://codereview.chromium.org/2625893003
Cr-Commit-Position: refs/heads/master@{#42223}
Committed: https://chromium.googlesource.com/v8/v8/+/e0a850318fc2898c13b1dcf999e074111bcc937e

[Jarin, 2017-01-11 11:30:51]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 11:30:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-01-11 11:32:10]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org, tebbi@chromium.org

[Jarin, 2017-01-11 11:32:11]

Could you take a look, please?

[Michael Starzinger, 2017-01-11 11:37:18]

LGTM. Nice!

https://codereview.chromium.org/2625893003/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/2625893003/diff/1/src/deoptimizer.cc#newcode3620
src/deoptimizer.cc:3620: CHECK(static_cast<size_t>(frame_index) <
frames().size());
nit: CHECK_LT

https://codereview.chromium.org/2625893003/diff/1/src/deoptimizer.cc#newcode3890
src/deoptimizer.cc:3890: CHECK(static_cast<size_t>(object_index) <
object_positions_.size());
nit: CHECK_LT

[commit-bot: I haz the power, 2017-01-11 11:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 11:55:50]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-01-11 12:19:42]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2017-01-11 12:19:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2625893003/#ps20001
(title: "Address reviewer's comments")

[commit-bot: I haz the power, 2017-01-11 12:19:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 12:48:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484137182844990,
"parent_rev": "96b03dd11161a7bcb584a5600240eb3210263990", "commit_rev":
"e0a850318fc2898c13b1dcf999e074111bcc937e"}

[commit-bot: I haz the power, 2017-01-11 12:48:49]

Description was changed from

==========
[deoptimizer] Insert more consistency checks.

This is mainly to catch a crash that we see in Canary with escape
analysis on.
==========

to

==========
[deoptimizer] Insert more consistency checks.

This is mainly to catch a crash that we see in Canary with escape
analysis on.

Review-Url: https://codereview.chromium.org/2625893003
Cr-Commit-Position: refs/heads/master@{#42223}
Committed:
https://chromium.googlesource.com/v8/v8/+/e0a850318fc2898c13b1dcf999e074111bc...
==========

[commit-bot: I haz the power, 2017-01-11 12:48:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e0a850318fc2898c13b1dcf999e074111bc...