Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2625873008: Fix crash in WritableStreamFinishClose (Closed)

Created:
3 years, 11 months ago by Adam Rice
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in WritableStreamFinishClose WritableStreamFinishClose would fail if the writer had been detached. Add checks to stop this happening. This updates the implementation to match Streams Standard version https://github.com/whatwg/streams/commit/347667724b8a4b83fcc379b730603cf4cd0d6e91 which is current as of 12 Jan 2017. Also update the tests to the same commit. BUG=658144 Review-Url: https://codereview.chromium.org/2625873008 Cr-Commit-Position: refs/heads/master@{#443201} Committed: https://chromium.googlesource.com/chromium/src/+/78dd11ea48a9967a31b7064cbdcea8eb61ca73dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/streams/WritableStream.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Adam Rice
3 years, 11 months ago (2017-01-12 06:01:48 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
3 years, 11 months ago (2017-01-12 08:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873008/1
3 years, 11 months ago (2017-01-12 09:05:41 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:45:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78dd11ea48a9967a31b7064cbdce...

Powered by Google App Engine
This is Rietveld 408576698