Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2625853002: Remove --v8-pac-mojo-in-process (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --v8-pac-mojo-in-process Part of removing the dependency of the browser DLL on Windows on V8. BUG=581766 Review-Url: https://codereview.chromium.org/2625853002 Cr-Commit-Position: refs/heads/master@{#443008} Committed: https://chromium.googlesource.com/chromium/src/+/273c31e1ab4a2180fbcbe2c1829b2c05717aa50e

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -136 lines) Patch
M chrome/browser/net/proxy_service_factory.cc View 1 1 chunk +1 line, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
D net/proxy/in_process_mojo_proxy_resolver_factory.h View 1 chunk +0 lines, -43 lines 0 comments Download
D net/proxy/in_process_mojo_proxy_resolver_factory.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M net/proxy/proxy_service_mojo.h View 1 chunk +0 lines, -16 lines 0 comments Download
M net/proxy/proxy_service_mojo.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M net/proxy/proxy_service_mojo_unittest.cc View 1 2 3 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
scottmg
3 years, 11 months ago (2017-01-11 19:43:08 UTC) #12
eroman
lgtm
3 years, 11 months ago (2017-01-11 19:48:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625853002/40001
3 years, 11 months ago (2017-01-11 20:06:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211261)
3 years, 11 months ago (2017-01-11 20:25:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625853002/40001
3 years, 11 months ago (2017-01-11 20:40:35 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:15:31 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/273c31e1ab4a2180fbcbe2c1829b...

Powered by Google App Engine
This is Rietveld 408576698