Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2625833003: [wasm][asm.js] Add flag to optionally suppress asm.js messages. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
Mircea Trofin, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Add flag to optionally suppress asm.js messages. Asm.js warnings / info is non-canonical. It may be useful to suppress it in golden file tests (for instance LayoutTests). BUG=v8:4203 R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2625833003 Cr-Commit-Position: refs/heads/master@{#42204} Committed: https://chromium.googlesource.com/v8/v8/+/b5071c87f46b21f3e23092b4a9e2d2885089e38a

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/asmjs/asm-js.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bradnelson
3 years, 11 months ago (2017-01-10 23:00:17 UTC) #4
Mircea Trofin
lgtm
3 years, 11 months ago (2017-01-10 23:02:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625833003/2
3 years, 11 months ago (2017-01-10 23:04:48 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 23:35:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:2) as
https://chromium.googlesource.com/v8/v8/+/b5071c87f46b21f3e23092b4a9e2d288508...

Powered by Google App Engine
This is Rietveld 408576698