Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2625823005:
arc: Fix crash in arc_process_task.cc during browser shutdown (Closed)
|
Created:
3 years, 11 months ago by Yusuke Sato Modified:
3 years, 11 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionarc: Fix crash in arc_process_task.cc during browser shutdown
Since TaskManagerImpl is destructed after ~ArcServiceManager is called,
we need to check the return value from the getter.
BUG=680301
TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC,
press Ctrl+Shift+QQ to sign out, confirm the browser does not crash
Review-Url: https://codereview.chromium.org/2625823005
Cr-Commit-Position: refs/heads/master@{#443304}
Committed: https://chromium.googlesource.com/chromium/src/+/ab4e21b712638087bdec923f9fcccf81ae1e2154
Patch Set 1 #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
yusukes@chromium.org changed reviewers: + hidehiko@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
(The trybot failures seem unrelated to my CL. The main waterfall is red and it's probably affecting the try bots too.)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by yusukes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yusukes@chromium.org
yusukes@chromium.org changed reviewers: + afakhry@chromium.org
+afakhry Could you do an OWNER review? Thanks!
lgtm
The CQ bit was checked by yusukes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484246540639690, "parent_rev":
"caf312f64306f7490999d4587d7b8426b0a6aa67", "commit_rev":
"ab4e21b712638087bdec923f9fcccf81ae1e2154"}
Message was sent while issue was closed.
Description was changed from ========== arc: Fix crash in arc_process_task.cc during browser shutdown Since TaskManagerImpl is destructed after ~ArcServiceManager is called, we need to check the return value from the getter. BUG=680301 TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC, press Ctrl+Shift+QQ to sign out, confirm the browser does not crash ========== to ========== arc: Fix crash in arc_process_task.cc during browser shutdown Since TaskManagerImpl is destructed after ~ArcServiceManager is called, we need to check the return value from the getter. BUG=680301 TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC, press Ctrl+Shift+QQ to sign out, confirm the browser does not crash Review-Url: https://codereview.chromium.org/2625823005 Cr-Commit-Position: refs/heads/master@{#443304} Committed: https://chromium.googlesource.com/chromium/src/+/ab4e21b712638087bdec923f9fcc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ab4e21b712638087bdec923f9fcc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
