MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used

chrome/browser/ui/test/test_browser_dialog.cc

Index: chrome/browser/ui/test/test_browser_dialog.cc
diff --git a/chrome/browser/ui/test/test_browser_dialog.cc b/chrome/browser/ui/test/test_browser_dialog.cc
index 5faa2fa206385a6c883b70d4f225e1dcb37158fa..18099e7c70ce4a68f65ce499052cacb1c00a85fe 100644
--- a/chrome/browser/ui/test/test_browser_dialog.cc
+++ b/chrome/browser/ui/test/test_browser_dialog.cc
@@ -88,11 +88,11 @@ void TestBrowserDialog::RunDialog() {
 
   gfx::NativeView parent = platform_util::GetViewForWindow(DialogParent());
   views::Widget::Widgets widgets_before;
-  views::Widget::GetAllChildWidgets(parent, &widgets_before);
+  views::Widget::GetAllOwnedWidgets(parent, &widgets_before);

[msw, 2017/01/13 23:23:51]

What's the reason behind these changes? (worth mentioning in cl desc)

[tapted, 2017/01/13 23:48:45]

whoops - I deleted that bit in an edit. Added back:

This uses the TestBrowserDialog framework, which was using
GetAllChildWidgets() to detect a dialog being added. This worked on Mac,
but on Aura the dialog is added as a "transient" child. Update
TestBrowserDialog to use GetAllOwnedWidgets(), which includes transient
children as well as other child windows.

 
   ShowDialog(NameFromTestCase());
   views::Widget::Widgets widgets_after;
-  views::Widget::GetAllChildWidgets(parent, &widgets_after);
+  views::Widget::GetAllOwnedWidgets(parent, &widgets_after);
 
   auto added = base::STLSetDifference<std::vector<views::Widget*>>(
       widgets_after, widgets_before);