MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used

chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 4b36627f5a2fe37738be16ef01465fd7087209dc..3e08f4677d62cdeb2d87461e2625ec1fa6a2267e 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -243,11 +243,11 @@ void OneClickSigninSyncStarter::OnRegisteredForPolicy(
 
   content::RecordAction(
       base::UserMetricsAction("Signin_Show_EnterpriseAccountPrompt"));
-  TabDialogs::FromWebContents(web_contents)->ShowProfileSigninConfirmation(
-      browser_,
-      profile_,
-      signin->GetUsernameForAuthInProgress(),
-      new SigninDialogDelegate(weak_pointer_factory_.GetWeakPtr()));

[tapted, 2017/01/13 22:53:18]

This is the leak - nothing would ever free the delegate allocated with `new`
here.

Plumbing through a unique_ptr seems right, although it's a lot of churn.

Another possibility: declare a function-local `static SigninDialogDelegate
delegate;` here and do `delegate.SetClient(weak_pointer_factory.GetWeakPtr());`
then pass the address of the local. I think that would work fine - there'd be
less codegen in the text segment, but of course the `leak` would be permanent
for everyone since the static needs space in the data segment.

I could also just restructure the test so that it doesn't expose the leak....

[msw, 2017/01/13 23:23:51]

Plumbing unique_ptr seems right to me; thanks for the fix!

+  TabDialogs::FromWebContents(web_contents)
+      ->ShowProfileSigninConfirmation(browser_, profile_,
+                                      signin->GetUsernameForAuthInProgress(),
+                                      base::MakeUnique<SigninDialogDelegate>(
+                                          weak_pointer_factory_.GetWeakPtr()));
 }
 
 void OneClickSigninSyncStarter::LoadPolicyWithCachedCredentials() {