Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2625803002: Disable LCD text in drag images (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
reed1
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable LCD text in drag images Since we don't know know whether the drag image is going to have an opaque backdrop, disable LCD text conservatively. This was previously handled by SkPictureImageGenerator, internally, but broke in http://crrev.com/2619573002. BUG=679307 R=reed@google.com Review-Url: https://codereview.chromium.org/2625803002 Cr-Commit-Position: refs/heads/master@{#442804} Committed: https://chromium.googlesource.com/chromium/src/+/ae554451211cf78a57a6257abf4943f679fa5298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
f(malita)
Unfortunately I cannot repro the failure in a layout test (presumably due to different LCD ...
3 years, 11 months ago (2017-01-10 21:25:48 UTC) #3
reed1
lgtm
3 years, 11 months ago (2017-01-11 03:12:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625803002/1
3 years, 11 months ago (2017-01-11 04:52:04 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:57:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae554451211cf78a57a6257abf49...

Powered by Google App Engine
This is Rietveld 408576698